Page MenuHomePhabricator
Create Task
Maniphest T301558

Mentor module ask a question dialog does not open if dialog is opened and page is reloaded
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to reproduce:

  • Click the button on Special:Homepage to ask your mentor a question
  • Enter some text in the textarea
  • Reload the page
  • Click the button to ask your mentor a question

Expected:

  • The dialog opens with your text prefilled

Actual:

  • The dialog does not open. No JS error is logged.

Details

SubjectRepoBranchLines +/-
Mentorship module: open ask question dialog if the URL has #/homepage/mentorship/questionmediawiki/extensions/GrowthExperimentsmaster+3 -0
Customize query in gerrit

Event Timeline

kostajh created this task.Feb 11 2022, 1:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2022, 1:34 PM
kostajh triaged this task as High priority.Feb 11 2022, 1:34 PM
kostajh changed the subtype of this task from "Task" to "Bug Report".
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh added a subscriber: Urbanecm_WMF.
• mewoph subscribed.EditedFeb 11 2022, 4:51 PM

The dialog is not opened regardless of whether there is text entered. I think the issue is that when reloading, the URL has #/homepage/mentorship/question but the dialog is not opened (and there is no hash change when the "Ask your mentor a question" button is clicked).

• mewoph claimed this task.Feb 11 2022, 8:56 PM
• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Feb 11 2022, 9:11 PM

Change 761992 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Mentorship module: open ask question dialog if the URL has #/homepage/mentorship/question

https://gerrit.wikimedia.org/r/761992

gerritbot added a project: Patch-For-Review.Feb 11 2022, 9:11 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 11 2022, 9:11 PM
gerritbot added a comment.Feb 12 2022, 12:48 PM

Change 761992 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentorship module: open ask question dialog if the URL has #/homepage/mentorship/question

https://gerrit.wikimedia.org/r/761992

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Feb 12 2022, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 12 2022, 1:10 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 12 2022, 4:14 PM
kostajh renamed this task from Mentor module ask a question dialog does not open if there is saved draft text to Mentor module ask a question dialog does not open if dialog is opened and page is reloaded.Feb 14 2022, 10:33 AM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.EditedFeb 15 2022, 2:15 AM
Etonkovidova subscribed.

Checked in betalabs and testwiki wmf.22 - works as expected.

Etonkovidova closed this task as Resolved.Feb 15 2022, 9:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits