Page MenuHomePhabricator

IPInfo accordion: Design changes for help popup
Closed, ResolvedPublic2 Estimated Story Points

Description

AC:

  1. Text inside the popup should not be bold
  2. Position the icon next to the title instead of the extreme right (T297957)
  3. When the popup opens it should be above the icon, not below (unless the user is scrolled in such a way that opening below is the only option)

Event Timeline

TThoabala set the point value for this task to 2.Feb 28 2022, 5:21 PM
TThoabala subscribed.

Documentation to for AC 3. here

Change 770018 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/IPInfo@master] Make some changes to the help popup styles

https://gerrit.wikimedia.org/r/770018

Change 770018 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Make some changes to the help popup styles

https://gerrit.wikimedia.org/r/770018

dom_walden subscribed.

I confirmed the acceptance criteria on Firefox 91, Chromium 87 and Safari 15 on Vector 2022, Vector 2010, MonoBook and Timeless.

I couldn't test on Minerva due to the infobox not being able to be expanded on that skin (which should be dealt with here: T302285#7788348).

Test environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (500d7c1) 07:44, 18 March 2022.