Page MenuHomePhabricator

For references with multiple templates, the calculation of overall adaptation status is wrong
Closed, ResolvedPublicBUG REPORT

Description

An example:

ig.wikipedia.org_wiki_Special_ContentTranslation_from=en&to=ig&page=James+Webb+Space+Telescope&targettitle=Telescopio+espacial+James+Webb(iPad Air).png (1×2 px, 693 KB)
ig.wikipedia.org_wiki_Special_ContentTranslation_from=en&to=ig&page=James+Webb+Space+Telescope&targettitle=Telescopio+espacial+James+Webb(iPad Air) copy.png (1×2 px, 218 KB)

Here there reference has two templates. First one is fully adapted. Second is not adapted because it is not available in target wiki. But the overall reference is marked as unadapted. It should be marked as partially adapted.

This is caused by a bug in the reference adaptation where overal status is considered partial if all template adaptation is partial. If some of the templates are partially or fully adapted the whole reference should be marked as partially adapted.

Event Timeline

Change 763471 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/services/cxserver@master] Reference: Fix the overall adaptation status calculation logic

https://gerrit.wikimedia.org/r/763471

Change 763471 merged by jenkins-bot:

[mediawiki/services/cxserver@master] Reference: Fix the overall adaptation status calculation logic

https://gerrit.wikimedia.org/r/763471

Change 765361 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Update cxserver to 2022-02-24-035645-production

https://gerrit.wikimedia.org/r/765361

Change 765361 merged by jenkins-bot:

[operations/deployment-charts@master] Update cxserver to 2022-02-24-035645-production

https://gerrit.wikimedia.org/r/765361

Mentioned in SAL (#wikimedia-operations) [2022-02-24T11:35:28Z] <kart_> Updated cxserver to 2022-02-24-035645-production (T301443, T301952)

Since this was a backend change and has tests, we can consider this is done. The actual references in the example screenshot is no longer available as the original English article has been rewritten a lot since Feb this year.

@santhosh I agre with this. If this is a backend change and then DEV testing is fine for this since there is no UI change. Moving this to done.