Page MenuHomePhabricator
Create Task
Maniphest T302313

🟪 Set up contract/schema test for GET /entities/items/{item_id}
Closed, ResolvedPublic
Actions

Description

Set up automated tests for the result of T302370 against the spec created in T302312.

Details

SubjectRepoBranchLines +/-
REST: Test non-empty item responsemediawiki/extensions/Wikibasemaster+537 -52
REST: Extract createEntity function for testsmediawiki/extensions/Wikibasemaster+26 -20
REST: Introduce tests against openapi specmediawiki/extensions/Wikibasemaster+61 -5
REST: Fix typo in global Item specificationmediawiki/extensions/Wikibasemaster+1 -1
REST: Run api-testing from the rest-api/ dirmediawiki/extensions/Wikibasemaster+1 K -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Feb 22 2022, 4:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2022, 4:06 PM
Jakob_WMDE removed a parent task: T302312: 🟪 Create OpenAPI spec section for GETting a single item.Feb 22 2022, 4:07 PM
Jakob_WMDE added a parent task: T302054: 🟪 Create a simple implementation of GET /entities/items/{item_id}.
Silvan_WMDE mentioned this in T302054: 🟪 Create a simple implementation of GET /entities/items/{item_id}.Feb 23 2022, 8:34 AM
Jakob_WMDE renamed this task from 🟪 Test happy path of GET /entities/items/{item_id} to 🟪 Set up contract/schema test for GET /entities/items/{item_id}.Mar 2 2022, 8:58 AM
Jakob_WMDE updated the task description. (Show Details)
Jakob_WMDE claimed this task.Mar 3 2022, 8:57 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 1) board.
gerritbot added a comment.Mar 4 2022, 9:47 AM

Change 768017 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Run api-testing from the rest-api/ dir

https://gerrit.wikimedia.org/r/768017

gerritbot added a project: Patch-For-Review.Mar 4 2022, 9:47 AM

Change 768018 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Ensure empty objects get serialized as `{}`

https://gerrit.wikimedia.org/r/768018

gerritbot added a comment.Mar 4 2022, 9:47 AM

Change 768019 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Introduce tests against openapi spec

https://gerrit.wikimedia.org/r/768019

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 1) board.Mar 4 2022, 10:18 AM
gerritbot added a comment.Mar 7 2022, 10:13 AM

Change 768666 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Extract createItem function for tests

https://gerrit.wikimedia.org/r/768666

gerritbot added a comment.Mar 7 2022, 1:16 PM

Change 768719 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Test non-empty item response

https://gerrit.wikimedia.org/r/768719

Jakob_WMDE removed Jakob_WMDE as the assignee of this task.Mar 7 2022, 5:56 PM
gerritbot added a comment.Mar 11 2022, 12:29 PM

Change 769952 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Fix typo in global Item specification

https://gerrit.wikimedia.org/r/769952

WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 2); removed Wikibase Product Platform (v1) (Sprint 1).Mar 14 2022, 1:11 PM
WMDE-leszek moved this task from To Do to Peer Review on the Wikibase Product Platform (v1) (Sprint 2) board.
gerritbot added a comment.Mar 14 2022, 4:37 PM

Change 768017 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Run api-testing from the rest-api/ dir

https://gerrit.wikimedia.org/r/768017

gerritbot added a comment.Mar 15 2022, 10:26 AM

Change 769952 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Fix typo in global Item specification

https://gerrit.wikimedia.org/r/769952

gerritbot added a comment.Mar 15 2022, 10:38 AM

Change 768019 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Introduce tests against openapi spec

https://gerrit.wikimedia.org/r/768019

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).Mar 15 2022, 11:00 AM
Silvan_WMDE claimed this task.Mar 15 2022, 11:38 AM
Silvan_WMDE moved this task from Peer Review to Doing on the Wikibase Product Platform (v1) (Sprint 2) board.
gerritbot added a comment.Mar 15 2022, 11:48 AM

Change 768666 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Extract createEntity function for tests

https://gerrit.wikimedia.org/r/768666

Silvan_WMDE removed Silvan_WMDE as the assignee of this task.Mar 16 2022, 10:45 AM
Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 2) board.
Silvan_WMDE subscribed.
gerritbot added a comment.Mar 17 2022, 1:51 PM

Change 768719 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Test non-empty item response

https://gerrit.wikimedia.org/r/768719

Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 2) board.Mar 18 2022, 9:17 AM
WMDE-leszek closed this task as Resolved.Mar 31 2022, 12:32 PM
WMDE-leszek claimed this task.
WMDE-leszek removed a subtask: T303926: 🔗 Include sitelinks in the contract test for GET /entities/items/{item_id}.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits