{item_id}
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Silvan_WMDE
	Mar 16 2022, 10:37 AM

Description

Currently, the CI system does not allow creating an item with a sitelink. It fails with the following error:

18:12:22   1) validate GET /entities/items/{id} responses against OpenAPI document
18:12:22        200 OK response is valid for a non-empty item:
18:12:22      AssertionError: User "<anon>": Action "wbeditentity" returned error code "not-recognized-site": Unknown site: wikidb!
18:12:22       at Client.action (node_modules/api-testing/lib/actionapi.js:123:11)
18:12:22       at processTicksAndRejections (internal/process/task_queues.js:95:5)
18:12:22       at async Object.createSingleItem (tests/mocha/helpers/entityHelper.js:60:9)
18:12:22       at async Context.<anonymous> (tests/mocha/openapi-validation/GetItemTest.js:38:36)
18:12:22 
18:12:22 
18:12:22 
18:12:22 ERROR: "api-testing:rest-api" exited with 1.

In order to fully contract-test the response of GET /entities/items/{item_id} against the OpenAPI schema, we should find out how to create an item with a sitelink and include it in the test.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	REST: Include sitelinks in GET item spec test	mediawiki/extensions/Wikibase	master	+12 -0

Customize query in gerrit

Related Objects

Mentioned Here: T314586: Enable Wikibase CI wikis to link to themselves

Event Timeline

Silvan_WMDE created this task.Mar 16 2022, 10:37 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2022, 10:37 AM

Silvan_WMDE renamed this task from Include sitelink in the contract test for GET /entities/items/{item_id} to Include sitelinks in the contract test for GET /entities/items/{item_id}.Mar 16 2022, 10:39 AM

Ollie.Shotton_WMDE added a project: Technical-Debt.Mar 16 2022, 11:57 AM

If we can't enable sitelinks in CI we could create separate sitelink test(s) that only run locally. For example, via an environment variable that is only set locally and mocha's if skip.

WMDE-leszek removed a parent task: T302313: 🟪 Set up contract/schema test for GET /entities/items/{item_id}.Mar 31 2022, 12:33 PM

WMDE-leszek moved this task from Backlog to Non Product on the Wikibase Product Platform (v1) board.Apr 11 2022, 8:03 PM

Looks like the hard part has been done in T314586 so testing sitelinks should be doable now.

Jakob_WMDE moved this task from Non Product to Sprint 13 on the Wikibase Product Platform (v1) board.Sep 20 2022, 9:15 AM

Jakob_WMDE edited projects, added Wikibase Product Platform (v1) (Sprint 13); removed Wikibase Product Platform (v1).

Jakob_WMDE claimed this task.Sep 21 2022, 8:33 AM

Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 13) board.

Ollie.Shotton_WMDE renamed this task from Include sitelinks in the contract test for GET /entities/items/{item_id} to 🔗 Include sitelinks in the contract test for GET /entities/items/{item_id}.Sep 21 2022, 8:39 AM

Change 833781 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Include sitelinks in GET item spec test

https://gerrit.wikimedia.org/r/833781

gerritbot added a project: Patch-For-Review.Sep 21 2022, 2:23 PM

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 13) board.Sep 21 2022, 2:44 PM

Change 833781 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Include sitelinks in GET item spec test

https://gerrit.wikimedia.org/r/833781

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 22 2022, 11:00 AM

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 13) board.Sep 22 2022, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2022, 11:30 AM

WMDE-leszek closed this task as Resolved.Oct 14 2022, 12:53 PM

🔗 Include sitelinks in the contract test for GET /entities/items/{item_id}Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

🔗 Include sitelinks in the contract test for GET /entities/items/{item_id}
Closed, ResolvedPublic
Actions