Enable Wikibase CI wikis to link to themselves
Closed, ResolvedPublic
Actions

Description

In order to integration-test T278962: Allow redirects and the target article as independent sitelinks if redirect badge is used (ideally using API integration tests), we need the test wiki in Wikibase CI jobs to be able to link to itself. Currently, this is not possible: the wiki must first be added to its own sites table, using a group that is then added to the $wgWBRepoSettings['siteLinkGroups'] array in its LocalSettings.php.

This would also be useful for browser tests (I think we currently don’t have any browser tests for sitelink behavior?), so I wouldn’t restrict this to the api-testing jobs.

Details

Subject	Repo	Branch	Lines +/-
jjb: Switch quibble jobs to 1.4.6	integration/config	master	+33 -33
dockerfiles: update to Quibble 1.4.6	integration/config	master	+68 -4
release: Quibble 1.4.6	integration/quibble	master	+18 -2
Run addSite script to allow setting sitelinks in tests	integration/quibble	master	+37 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Manuel	T54564 Allow sitelinks to redirect pages to fix the 'Bonnie and Clyde problem'
Open		Manuel	T320491 [EPIC] Solve the Bonnie & Clyde problem
Resolved	Feature	Manuel	T278962 Allow redirects and the target article as independent sitelinks if redirect badge is used
Resolved		Michael	T314586 Enable Wikibase CI wikis to link to themselves

Event Timeline

Lucas_Werkmeister_WMDE created this task.Aug 4 2022, 3:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2022, 3:29 PM

I can see three ways to implement this at the moment:

Quibble adds another step to InstallMediaWiki (quibble/command.py) where, after running update.php (and either before or after rebuildLocalisationCache.php), it runs the addSite.php maintenance script, using a certain well-known group name (“local”, “CI”, whatever). We add that group name to the $wgWBRepoSettings['siteLinkGroups'] in Wikibase’s repo/config/Wikibase.ci.php.

Wikibase.ci.php automatically adds an entry for the local wiki to the sites table if it’s not present yet (or perhaps only if the sites table is completely empty); it also still sets $wgWBRepoSettings['siteLinkGroups'].

Wikibase “synthesizes” the site at runtime (e.g. in the SiteLinkTargetProvider service) even if it doesn’t exist in the sites table, controlled by a new CI-only setting that is set by Wikibase.ci.php.

I don’t like that option 1 requires shared knowledge of the group name between Quibble and Wikibase’s CI file; also, this would mean that the tests we want to write are blocked until the next Quibble version is released and used in CI. But in option 2, a PHP file that’s ostensibly config-only would magically change the database, which seems fairly evil; and option 3 feels risky, because who knows how many places assume that a site link target really exists in the sites table (or even just in the SiteLookup service, which is a MediaWiki core service where we might not be able to insert the “synthetic” site). So at the moment, I’m leaning towards option 1.

Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Aug 4 2022, 3:46 PM

Michael added a project: wmde-wikidata-tech.Aug 4 2022, 4:55 PM

Michael added a subscriber: ItamarWMDE.

Change 820744 had a related patch set uploaded (by Michael Große; author: Michael Große):

[integration/quibble@master] Run addSite script to allow setting sitelinks

https://gerrit.wikimedia.org/r/820744

gerritbot added a project: Patch-For-Review.Aug 8 2022, 4:13 PM

Eugene subscribed.Aug 9 2022, 9:16 AM

Michael claimed this task.Aug 9 2022, 9:33 AM

Restricted Application added a project: User-Michael. · View Herald TranscriptAug 9 2022, 9:33 AM

Michael removed Michael as the assignee of this task.Aug 12 2022, 3:54 PM

Michael moved this task from Todo/Backlog to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Aug 30 2022, 1:06 PM