Maniphest T302953

Deprecate wasDeadlock/wasLockTimeout/wasConnectionLoss as public IDatabase methods
Closed, ResolvedPublic
Actions

Description

These methods have no public callers.

Details

	Subject	Repo	Branch	Lines +/-
	Remove three unused IDatabase::was* methods	mediawiki/core	master	+4 -79

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ladsgroup	T299691 Break down monster class: Database
		Resolved		Ladsgroup	T302953 Deprecate wasDeadlock/wasLockTimeout/wasConnectionLoss as public IDatabase methods

Event Timeline

aaron created this task.Mar 3 2022, 5:35 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2022, 5:35 AM

aaron renamed this task from wasDeadlock to Deprecate wasDeadlock/wasLockTimeout/wasConnectionLoss as public IDatabase methods.Mar 3 2022, 5:37 AM

aaron added a project: MediaWiki-libs-Rdbms.

aaron updated the task description. (Show Details)

Restricted Application added a project: Performance-Team. · View Herald TranscriptMar 3 2022, 5:37 AM

aaron moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Mar 7 2022, 7:25 PM

Krinkle triaged this task as Low priority.Mar 30 2022, 12:30 AM

Krinkle moved this task from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.

Krinkle added a parent task: T299691: Break down monster class: Database.Apr 7 2022, 6:52 PM

Krinkle added a project: Technical-Debt (Deprecation process).

Krinkle moved this task from Untriaged to 2022 | MW 1.38 / 1.39 on the Technical-Debt (Deprecation process) board.

Confirmed, no callers:
https://codesearch.wmcloud.org/search/?q=%3E(wasDeadlock%7CwasLockTimeout%7CwasConnectionLoss)&i=nope&files=&excludeFiles=&repos=

Definitions:
https://codesearch.wmcloud.org/search/?q=ion%20(wasDeadlock%7CwasLockTimeout%7CwasConnectionLoss)&i=nope&files=&excludeFiles=&repos=

Change 743250 had a related patch set uploaded (by Krinkle; author: Amir Sarabadani):

[mediawiki/core@master] Remove four unused IDatabase::was* methods

https://gerrit.wikimedia.org/r/743250

gerritbot added a project: Patch-For-Review.Apr 11 2023, 9:23 PM

Change 743250 merged by jenkins-bot:

[mediawiki/core@master] Remove three unused IDatabase::was* methods

https://gerrit.wikimedia.org/r/743250

Krinkle closed this task as Resolved.Apr 12 2023, 12:51 AM

Krinkle assigned this task to Ladsgroup.

Krinkle removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 12 2023, 1:00 AM