Revision history not showing
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Mar 4 2022, 9:28 AM

Description

What is the problem?

Looking at the revision history of a page returns no results, just:

No matching revisions were found.

I am finding this on beta and my local docker.

Steps to reproduce problem

Go to https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Main_Page&action=history

Expected behavior: See revision history.
Observed behavior: See no results.

Environment

Wiki(s): https://en.wikipedia.beta.wmflabs.org MediaWiki 1.38.0-alpha (df7acbd) 07:07, 4 March 2022.

Details

Subject	Repo	Branch	Lines +/-
Handle null in ChangeTags::modifyDisplayQuery	mediawiki/core	REL1_35	+66 -4
Handle null in ChangeTags::modifyDisplayQuery	mediawiki/core	REL1_37	+66 -4
Handle null in ChangeTags::modifyDisplayQuery	mediawiki/core	master	+66 -4

Customize query in gerrit

Related Objects

Mentioned In: T296642: MediaWiki makes it possible to create tag '0', but it doesn't work
Mentioned Here: rMWdf7acbd466af: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Mar 4 2022, 9:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2022, 9:28 AM

dom_walden added a project: MediaWiki-Page-history.Mar 4 2022, 9:33 AM

dom_walden added a parent task: T300201: 1.38.0-wmf.25 deployment blockers.Mar 4 2022, 9:40 AM

Ammarpad triaged this task as Unbreak Now! priority.Mar 4 2022, 9:44 AM

dom_walden mentioned this in T296642: MediaWiki makes it possible to create tag '0', but it doesn't work.Mar 4 2022, 9:46 AM

This seems to be a fallout from https://gerrit.wikimedia.org/r/c/mediawiki/core/+/743562

matej_suchanek claimed this task.Mar 4 2022, 10:02 AM

Was about to report the same. Workaround: specify a date, like https://en.wikipedia.beta.wmflabs.org/w/index.php?date-range-to=2022-03-04&tagfilter=&title=Bert&action=history.

Change 768023 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/core@master] Handle null in ChangeTags::modifyDisplayQuery

https://gerrit.wikimedia.org/r/768023

gerritbot added a project: Patch-For-Review.Mar 4 2022, 10:20 AM

Test wiki created on Patch demo by Matěj Suchánek using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/14845526eb/w/

Change 768023 merged by jenkins-bot:

[mediawiki/core@master] Handle null in ChangeTags::modifyDisplayQuery

https://gerrit.wikimedia.org/r/768023

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 4 2022, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2022, 1:10 PM

Ammarpad closed this task as Resolved.Mar 4 2022, 2:48 PM

Ammarpad removed a parent task: T300201: 1.38.0-wmf.25 deployment blockers.

AlexisJazz unsubscribed.Mar 4 2022, 3:11 PM

Change 809950 had a related patch set uploaded (by Reedy; author: Matěj Suchánek):

[mediawiki/core@REL1_35] Handle null in ChangeTags::modifyDisplayQuery

https://gerrit.wikimedia.org/r/809950

Change 809951 had a related patch set uploaded (by Reedy; author: Matěj Suchánek):

[mediawiki/core@REL1_37] Handle null in ChangeTags::modifyDisplayQuery

https://gerrit.wikimedia.org/r/809951

Change 809951 merged by jenkins-bot:

[mediawiki/core@REL1_37] Handle null in ChangeTags::modifyDisplayQuery

https://gerrit.wikimedia.org/r/809951

Change 809950 merged by jenkins-bot:

[mediawiki/core@REL1_35] Handle null in ChangeTags::modifyDisplayQuery

https://gerrit.wikimedia.org/r/809950

Maintenance_bot removed a project: Patch-For-Review.Jun 30 2022, 4:30 PM

Test wiki on Patch demo by Matěj Suchánek using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/14845526eb/w/~~

ReleaseTaggerBot added projects: MW-1.35-notes, MW-1.37-notes.Jul 11 2022, 10:01 PM

Revision history not showingClosed, ResolvedPublicBUG REPORTActions