function-schemata: In many QUnit tests, the arg expected and actual are swapped around
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	gengh
	Mar 21 2022, 6:55 PM

Description

Phpunit tests assert statements put expected value first and actual value next, while QUnit assert methods do the opposite, first is actual and then expected. (https://api.qunitjs.com/assert/deepEqual/)

Currently in function-schemata tests (QUnit) we are putting the expected value before the actual. This doesn't mess up the tests, but when failures happen, the actual and expected values shown in console are interchanged which makes people go sad when trying to figure out what's happening.

Details

Subject	Repo	Branch	Lines +/-
Update function-schemata sub-module to HEAD (b193f0c)	mediawiki/services/function-evaluator	master	+1 -1
Update function-schemata sub-module to HEAD (88f1588)	mediawiki/services/function-orchestrator	master	+1 -1
Update function-schemata sub-module to HEAD (b193f0c)	mediawiki/tools/wikilambda-cli	master	+1 -1
Update function-schemata sub-module to HEAD (b193f0c)	mediawiki/extensions/WikiLambda	master	+1 -1
Ensure that all applicable QUnit tests supply actual value before expected value.	mediawiki/services/function-schemata	master	+26 -26

Customize query in gerrit

Related Objects

Mentioned In: rMSFEcb7f24b0c32f: Update function-schemata sub-module to HEAD (b193f0c)
rMSFOc01a058481f8: Update function-schemata sub-module to HEAD (88f1588)
rMTWC973c341a03e8: Update function-schemata sub-module to HEAD (b193f0c)
rMSFS486c46a82c96: Ensure that all applicable QUnit tests supply actual value before expected…

Event Timeline

gengh created this task.Mar 21 2022, 6:55 PM

DVrandecic moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Mar 22 2022, 4:28 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:46 PM

Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:36 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).

cmassaro claimed this task.Feb 1 2023, 12:31 PM

Change 885803 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Ensure that all applicable QUnit tests supply actual value before expected value.

https://gerrit.wikimedia.org/r/885803

gerritbot added a project: Patch-For-Review.Feb 1 2023, 1:13 PM

Change 885803 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Ensure that all applicable QUnit tests supply actual value before expected value.

https://gerrit.wikimedia.org/r/885803

cmassaro mentioned this in rMSFS486c46a82c96: Ensure that all applicable QUnit tests supply actual value before expected….Feb 2 2023, 2:46 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 2 2023, 3:30 PM

Change 886071 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (b193f0c)

https://gerrit.wikimedia.org/r/886071

Change 886072 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (b193f0c)

https://gerrit.wikimedia.org/r/886072

Change 886073 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (b193f0c)

https://gerrit.wikimedia.org/r/886073

Change 886075 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (b193f0c)

https://gerrit.wikimedia.org/r/886075

Change 886124 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (b193f0c)

https://gerrit.wikimedia.org/r/886124

Change 886073 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (b193f0c)

https://gerrit.wikimedia.org/r/886073

Change 886071 merged by jenkins-bot:

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (b193f0c)

https://gerrit.wikimedia.org/r/886071

Jdforrester-WMF mentioned this in rMTWC973c341a03e8: Update function-schemata sub-module to HEAD (b193f0c).Feb 7 2023, 6:26 PM

Change 886124 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (88f1588)

https://gerrit.wikimedia.org/r/886124

Jdforrester-WMF mentioned this in rMSFOc01a058481f8: Update function-schemata sub-module to HEAD (88f1588).Feb 9 2023, 5:56 PM

Change 886072 merged by Jforrester: