Page MenuHomePhabricator
Create Task
Maniphest T304648

function-schemata: createUserDefined has strange code, figure out if this is error or is intentional, and comment the code in case it is
Closed, ResolvedPublic
Actions

Description

For more details read comments in function-schemata/src/schema.js:createUserDefined() function.

Details

SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (d41dee3)mediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (d41dee3)mediawiki/tools/wikilambda-climaster+1 -1
Update function-schemata sub-module to HEAD (d41dee3)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (d41dee3)mediawiki/services/function-evaluatormaster+3 -3
Update function-schemata sub-module to HEAD (d41dee3)mediawiki/services/function-evaluatormaster+1 -1
Add comment explaining why we iterate over Z4s twice when creating user-defined schemata.mediawiki/services/function-schematamaster+5 -5
Customize query in gerrit

Related Objects

Event Timeline

gengh created this task.Mar 24 2022, 7:12 PM
Jdforrester-WMF moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Apr 19 2022, 4:11 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.
cmassaro mentioned this in T314926: Generic types are not fully evaluated, wrongly returning errors.Aug 11 2022, 11:04 AM
cmassaro mentioned this in T314994: Validators Created from User-Defined Types Are Sometimes Null.Aug 11 2022, 11:09 AM
gerritbot added a comment.Sep 30 2022, 9:27 PM

Change 837196 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Add comment explaining why we iterate over Z4s twice when creating user-defined schemata.

https://gerrit.wikimedia.org/r/837196

gerritbot added a project: Patch-For-Review.Sep 30 2022, 9:27 PM
cmassaro claimed this task.Sep 30 2022, 9:27 PM
gerritbot added a comment.Oct 5 2022, 7:05 PM

Change 837196 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Add comment explaining why we iterate over Z4s twice when creating user-defined schemata.

https://gerrit.wikimedia.org/r/837196

cmassaro mentioned this in rMSFS061801b7f8b1: Add comment explaining why we iterate over Z4s twice when creating user-defined….Oct 5 2022, 7:06 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 5 2022, 7:30 PM
gerritbot added a comment.Oct 7 2022, 2:34 PM

Change 840147 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (d41dee3)

https://gerrit.wikimedia.org/r/840147

gerritbot added a project: Patch-For-Review.Oct 7 2022, 2:34 PM

Change 840148 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (d41dee3)

https://gerrit.wikimedia.org/r/840148

gerritbot added a comment.Oct 7 2022, 2:39 PM

Change 840149 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (d41dee3)

https://gerrit.wikimedia.org/r/840149

gerritbot added a comment.Oct 7 2022, 6:17 PM

Change 840205 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (d41dee3)

https://gerrit.wikimedia.org/r/840205

gerritbot added a comment.Oct 7 2022, 6:17 PM

Change 840206 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (d41dee3)

https://gerrit.wikimedia.org/r/840206

gerritbot added a comment.Oct 7 2022, 6:23 PM

Change 840205 abandoned by Jforrester:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (d41dee3)

Reason:

https://gerrit.wikimedia.org/r/840205

gerritbot added a comment.Oct 7 2022, 6:29 PM

Change 840148 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (d41dee3)

https://gerrit.wikimedia.org/r/840148

gerritbot added a comment.Oct 7 2022, 6:30 PM

Change 840149 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (d41dee3)

https://gerrit.wikimedia.org/r/840149

Jdforrester-WMF mentioned this in rMSFO28dcc93ce059: Update function-schemata sub-module to HEAD (d41dee3).Oct 7 2022, 6:30 PM
Jdforrester-WMF mentioned this in rMSFE5926cf41dc8f: Update function-schemata sub-module to HEAD (d41dee3).
gerritbot added a comment.Oct 18 2022, 12:05 AM

Change 840206 merged by jenkins-bot:

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (d41dee3)

https://gerrit.wikimedia.org/r/840206

gerritbot added a comment.Oct 18 2022, 12:07 AM

Change 840147 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (d41dee3)

https://gerrit.wikimedia.org/r/840147

Jdforrester-WMF mentioned this in rMTWCe597ff3ed782: Update function-schemata sub-module to HEAD (d41dee3).Oct 18 2022, 12:50 AM
Jdforrester-WMF closed this task as Resolved.Oct 24 2022, 8:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL