Generic types are not fully evaluated, wrongly returning errors
Open, HighPublicBUG REPORT
Actions

Assigned To

Authored By

	• AAssaf
	Aug 10 2022, 10:40 AM

Description

Steps to replicate:

Define a generic type function that returns a type such as "Z8"
Use that generic type as the type of an argument to another function.

Example: https://gerrit.wikimedia.org/r/c/mediawiki/services/function-orchestrator/+/822057

What happens:

Error during evaluation "Could not dereference Z7K1". However by adding more logging (see https://phabricator.wikimedia.org/T314927) I see that the underlying issue is: 'Generic type function did not return a Z4: {"Z1K1":"Z9","Z9K1":"Z8"}'

What should have happened instead:

'{"Z1K1":"Z9","Z9K1":"Z8"}' is a reference that just needs to be recursively evaluated to a 'Z4'

Here is the culprit: https://github.com/wikimedia/mediawiki-services-function-orchestrator/blob/1c3ae6ee52209e7952747c1dcae5dfb27ff1843a/src/ZWrapper.js#L130. The resolve() call here does not resolve references.

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T349060 User rights: Create and edit types
Open		None	T343469 Improve the Types creation/editing and use system so we can open it up for community members
Open		None	T321827 Switch to a More Eager Evaluation Strategy
Open	BUG REPORT	DVrandecic	T314926 Generic types are not fully evaluated, wrongly returning errors
Resolved	BUG REPORT	gengh	T326301 FunctionEditor: I cannot choose function calls which returning types as input or output types of functions

Event Timeline

• AAssaf created this task.Aug 10 2022, 10:40 AM

• AAssaf updated the task description. (Show Details)

• AAssaf added a subscriber: • OZhang-WMF.

• AAssaf updated the task description. (Show Details)Aug 10 2022, 10:47 AM

• AAssaf updated the task description. (Show Details)

• AAssaf renamed this task from Generic function types are not fully evaluated, wrongly returning errors to Generic types are not fully evaluated, wrongly returning errors.Aug 10 2022, 10:56 AM

cmassaro added a comment.Aug 11 2022, 11:04 AM

This comment was removed by cmassaro.

cmassaro added a project: function-orchestrator.Aug 11 2022, 11:11 AM

There's a list of built-in types in function-schemata:javascript/src/utils.js (look for the isUserDefined) function.

utils should probably export a function like isType, which returns true if either

validatesAsType( object ).isValid() is true OR
validatesAsReference( object ).isValid() is true AND isUserDefined( object.Z9K1 ) is false

DVrandecic moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Aug 16 2022, 6:49 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

Jdforrester-WMF added a parent task: T321113: Audit and update creation and manipulation of errors in the orchestrator and evaluator.Oct 18 2022, 6:51 PM

Jdforrester-WMF moved this task from Incoming to Ready: Errors on the Abstract Wikipedia team (Phase θ – Throttling) board.Oct 25 2022, 6:41 PM

cmassaro added a parent task: T321827: Switch to a More Eager Evaluation Strategy.Oct 27 2022, 3:48 PM

cmassaro moved this task from Ready: Errors to Ready: G2. Correct & efficient on the Abstract Wikipedia team (Phase θ – Throttling) board.Oct 27 2022, 3:56 PM

DVrandecic claimed this task.Dec 22 2022, 11:55 PM

DVrandecic moved this task from Ready: G2. Correct & efficient to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.

DVrandecic added a subtask: T326301: FunctionEditor: I cannot choose function calls which returning types as input or output types of functions.Jan 7 2023, 1:49 AM

DVrandecic moved this task from QA / Ready to close to Ready: G9. Cleanup after default component implementation on the Abstract Wikipedia team (Phase θ – Throttling) board.

Is this still happening? @DVrandecic , feel free to assign this to me if it still needs to be looked at.

Hi and thank you for your interest! Please check thoroughly https://www.mediawiki.org/wiki/New_Developers (and all of its communication section!). The page covers how to get started, assigning tasks, task status, how to find a codebase, how to create patches, where to ask general development questions and where to get help with setup problems, and how to ask good questions. Thanks a lot! :)

Jdforrester-WMF moved this task from Phase θ – Throttling to Phase λ – Launch on the Abstract Wikipedia team board.Jun 16 2023, 9:03 AM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase λ – Launch); removed Abstract Wikipedia team (Phase θ – Throttling).

Jdforrester-WMF moved this task from Incoming to Engineering tasks on the Abstract Wikipedia team (Phase λ – Launch) board.Jun 16 2023, 9:40 AM

Jdforrester-WMF triaged this task as High priority.Jul 13 2023, 4:54 PM

Jdforrester-WMF moved this task from Phase λ – Launch to To triage: Nice-to-haves on the Abstract Wikipedia team board.

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase λ – Launch).

Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.Sep 25 2023, 5:43 PM

AAlhazwani-WMF changed the status of subtask T326301: FunctionEditor: I cannot choose function calls which returning types as input or output types of functions from Open to In Progress.Sep 29 2023, 9:17 AM

Jdforrester-WMF added a parent task: T343469: Improve the Types creation/editing and use system so we can open it up for community members.Oct 12 2023, 4:45 PM

Jdforrester-WMF removed a parent task: T321113: Audit and update creation and manipulation of errors in the orchestrator and evaluator.Oct 23 2023, 6:21 PM

Jdforrester-WMF closed subtask T326301: FunctionEditor: I cannot choose function calls which returning types as input or output types of functions as Resolved.Jan 4 2024, 1:30 PM

ecarg subscribed.Mar 19 2024, 7:52 PM