Page MenuHomePhabricator
Create Task
Maniphest T326301

FunctionEditor: I cannot choose function calls which returning types as input or output types of functions
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
gengh
Authored By
gengh
Jan 5 2023, 11:48 AM
Tags
Referenced Files
F37974515: CleanShot 2023-10-04 at 18.19.23@2x.png
Oct 4 2023, 4:19 PM
F37848795: image.png
Sep 29 2023, 11:18 AM
F37848780: image.png
Sep 29 2023, 11:18 AM
F37848728: image.png
Sep 29 2023, 11:18 AM
Subscribers
AAlhazwani-WMF
DVrandecic
gengh
Jdforrester-WMF

Description

Description

This means that I cannot have a list or a pair as a input or output of a function.

Steps to reproduce:

  1. Go to https://wikifunctions.beta.wmflabs.org/wiki/Special:CreateZObject?zid=Z8
  2. In input type or output type, write "Typed"

Observed behavior:

  • No typed list comes as option
  • This means that no Z8 returning a Z4 is returned in this ZObjectSelector, only persisted objects of type Z4

Expected behavior (Acceptance criteria):

  • Typed list or Typed pair should be available for selection as input or output types
  • When searching for a persisted object to select as input or output type, the request shouldn't ask only for type=Z4, but also returnType=Z4 so that also functions returning types are presented as options

Devices and Design (URLs or screenshots)

https://www.figma.com/file/Q6EG8mLJFhxw99HpffHSZe/T326301-Typed-list-as-function-input-or-output?node-id=518%3A39808&mode=dev

Completion checklist

Details

SubjectRepoBranchLines +/-
Add generic type list selector for function inputs and outputmediawiki/extensions/WikiLambdamaster+1 K -1 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Jan 5 2023, 11:48 AM
gengh moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.
gengh edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
gengh moved this task from Incoming to Ready: G4. Function view on the Abstract Wikipedia team (Phase θ – Throttling) board.
Jdforrester-WMF renamed this task from FunctionEditor: I cannot choose function calls returning types as input our output types of functions to FunctionEditor: I cannot choose function calls which returning types as input or output types of functions.Jan 5 2023, 4:39 PM
Jdforrester-WMF subscribed.

This is the use case we have the mode selector for, but we dropped it from the function editor design; should we re-add it?

DVrandecic subscribed.Jan 5 2023, 7:23 PM

Yes, we will need a mode selector here.

This should be built once we have the default component back. Thus moved to G9.

DVrandecic moved this task from Ready: G4. Function view to Ready: G9. Cleanup after default component implementation on the Abstract Wikipedia team (Phase θ – Throttling) board.Jan 5 2023, 7:23 PM
DVrandecic added a parent task: T314926: Generic types are not fully evaluated, wrongly returning errors.Jan 7 2023, 1:49 AM
Jdforrester-WMF moved this task from Phase θ – Throttling to Phase λ – Launch on the Abstract Wikipedia team board.Jun 16 2023, 9:00 AM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase λ – Launch); removed Abstract Wikipedia team (Phase θ – Throttling).
Jdforrester-WMF moved this task from Incoming to Engineering tasks on the Abstract Wikipedia team (Phase λ – Launch) board.Jun 16 2023, 9:38 AM
Jdforrester-WMF triaged this task as High priority.Jul 13 2023, 4:55 PM
Jdforrester-WMF moved this task from Phase λ – Launch to To triage: Nice-to-haves on the Abstract Wikipedia team board.
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase λ – Launch).
AAlhazwani-WMF changed the task status from Open to In Progress.Sep 29 2023, 9:17 AM
AAlhazwani-WMF claimed this task.
AAlhazwani-WMF added a comment.EditedSep 29 2023, 11:18 AM

early design proposal available at https://www.figma.com/file/Q6EG8mLJFhxw99HpffHSZe/T326301-Typed-list-as-function-input-or-output?type=design&node-id=110%3A20430&mode=dev

questions from engineering

  1. how to set up an input type as a typed list?
    • the proposal would be to use the same type selector, and display all objects that return Z4
      image.png (662×1 px, 95 KB)
  1. how to select the type of list items?
    • based on the selected type, we would display the additional required inputs just below the type selector
      image.png (990×2 px, 131 KB)
  1. edge case; nested lists: How to set up an input type as a typed list of typed lists?
    • same as above
      image.png (1×1 px, 131 KB)
  1. edge case; revert: After setting up an input type as a typed list, how do I change it back to a referenced type?
    • function creators can focus the type selector and pick a different object that returns a Z4
  1. how are input/output types shown in the Function Viewer details tab when they are function call defined types?
    • as a first iteration, we could rely on the existing solution that we use for function calls
      CleanShot 2023-10-04 at 18.19.23@2x.png (1×1 px, 172 KB)
AAlhazwani-WMF attached a referenced file: F37974515: CleanShot 2023-10-04 at 18.19.23@2x.png. (Show Details)Oct 4 2023, 4:20 PM
In T326301#9210047, @AAlhazwani-WMF wrote:
  1. how are input/output types shown in the Function Viewer details tab when they are function call defined types?
    • as a first iteration, we could rely on the existing solution that we use for function calls
      CleanShot 2023-10-04 at 18.19.23@2x.png (1×1 px, 172 KB)

edited message above.

Jdforrester-WMF added a parent task: T343469: Improve the Types creation/editing and use system so we can open it up for community members.Oct 12 2023, 4:45 PM
Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.
gengh claimed this task.Oct 30 2023, 9:29 AM
gengh updated the task description. (Show Details)
gengh updated the task description. (Show Details)
gengh added a subscriber: AAlhazwani-WMF.
gerritbot added a comment.Oct 30 2023, 2:18 PM

Change 969718 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Add generic type list selector for function inputs and output

https://gerrit.wikimedia.org/r/969718

gerritbot added a project: Patch-For-Review.Oct 30 2023, 2:18 PM
Jdforrester-WMF moved this task from Backlog to In Progress on the Abstract Wikipedia team board.Oct 30 2023, 2:22 PM
gerritbot added a comment.Nov 14 2023, 4:19 PM

Change 969718 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add generic type list selector for function inputs and output

https://gerrit.wikimedia.org/r/969718

Maintenance_bot removed a project: Patch-For-Review.Nov 14 2023, 4:31 PM
Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Nov 14 2023, 4:45 PM
Jdforrester-WMF added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 16 2023, 6:00 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Nov 29 2023, 10:43 PM
Jdforrester-WMF closed this task as Resolved.Jan 4 2024, 1:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits