Page MenuHomePhabricator
Create Task
Maniphest T304783

LocalSettings.php is missing page gives deprecation warnings
Closed, ResolvedPublicBUG REPORT
Actions

Description

If you go to install mediawiki, and have error reporting enabled, the first page you hit (LocalSettings.php is missing) gives the following warnings:

Deprecated: Premature access to service container [Called from TemplateParser::getTemplate in /var/www/html/w/includes/TemplateParser.php at line 115] in /var/www/html/w/includes/debug/MWDebug.php on line 377

Deprecated: Premature access to service 'HookContainer' [Called from MediaWiki\MediaWikiServices::getInstance in /var/www/html/w/includes/MediaWikiServices.php at line 282] in /var/www/html/w/includes/debug/MWDebug.php on line 377

Deprecated: Premature access to service 'ObjectFactory' [Called from Wikimedia\Services\ServiceContainer::{closure} in /var/www/html/w/includes/ServiceWiring.php at line 687] in /var/www/html/w/includes/debug/MWDebug.php on line 377

Deprecated: Premature access to service 'MainConfig' [Called from TemplateParser::getTemplate in /var/www/html/w/includes/TemplateParser.php at line 115] in /var/www/html/w/includes/debug/MWDebug.php on line 377

Deprecated: Premature access to service 'ConfigFactory' [Called from Wikimedia\Services\ServiceContainer::{closure} in /var/www/html/w/includes/ServiceWiring.php at line 906] in /var/www/html/w/includes/debug/MWDebug.php on line 377

Deprecated: Premature access to service 'BootstrapConfig' [Called from Wikimedia\Services\ServiceContainer::{closure} in /var/www/html/w/includes/ServiceWiring.php at line 392] in /var/www/html/w/includes/debug/MWDebug.php on line 377

This is a pretty bad user experience. We should try and fix this before releasing 1.38.

Details

SubjectRepoBranchLines +/-
TemplateParser: avoid warnings when called by NoLocalSettings.mediawiki/coreREL1_38+5 -3
TemplateParser: avoid warnings when called by NoLocalSettings.mediawiki/coreREL1_37+5 -3
TemplateParser: avoid warnings when called by NoLocalSettings.mediawiki/coreREL1_36+5 -3
TemplateParser: avoid warnings when called by NoLocalSettings.mediawiki/coreREL1_35+5 -3
TemplateParser: avoid warnings when called by NoLocalSettings.mediawiki/coremaster+5 -4
Customize query in gerrit

Related Objects

Event Timeline

Bawolff created this task.Mar 27 2022, 8:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2022, 8:32 AM
Reedy added a comment.Mar 27 2022, 9:05 AM

This feels dupe-y...

T273261: Premature access to service container but that's not specifically about the installer

Jdforrester-WMF subscribed.Apr 13 2022, 1:43 PM

Is this a new warning in 1.38? If not, I don't think this should be a blocker.

Jdforrester-WMF moved this task from Blocker to Not a blocker on the MW-1.38-release board.Apr 13 2022, 1:44 PM
daniel subscribed.Apr 13 2022, 3:26 PM

How do you enable error reporting if there is now LocalSettings.php?
I'd like to try and reproduce.

daniel added a comment.EditedApr 13 2022, 5:18 PM

The problem is that TemplateParser::getTemplate wants to access the config, to get the secret key for use in caching:

$config = MediaWikiServices::getInstance()->getMainConfig();
$secretKey = $config->get( 'SecretKey' );

That was introduced in 2016 by this commiet https://gerrit.wikimedia.org/r/c/mediawiki/core/+/323083 (which I approved at the time).

I'll make a patch for 1.39. I don't think it needs fixing in 1.38, since it ghas been around for years without anyone noticing. But backporting is trivial enough if anyone feels like it.

gerritbot added a comment.Apr 13 2022, 5:24 PM

Change 779916 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] TemplateParser: avoid warnings when called by NoLocalSettings.

https://gerrit.wikimedia.org/r/779916

gerritbot added a project: Patch-For-Review.Apr 13 2022, 5:24 PM
gerritbot added a comment.Apr 13 2022, 6:38 PM

Change 779916 merged by jenkins-bot:

[mediawiki/core@master] TemplateParser: avoid warnings when called by NoLocalSettings.

https://gerrit.wikimedia.org/r/779916

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).Apr 13 2022, 7:00 PM
Reedy added a comment.Apr 13 2022, 7:29 PM
In T304783#7852999, @daniel wrote:

I'll make a patch for 1.39. I don't think it needs fixing in 1.38, since it ghas been around for years without anyone noticing. But backporting is trivial enough if anyone feels like it.

It feels dejavu. I feel like TemplateParser has caused similar problems elsewhere, but couldn't find a task offhand...

gerritbot added a comment.Apr 13 2022, 7:30 PM

Change 779872 had a related patch set uploaded (by Reedy; author: Daniel Kinzler):

[mediawiki/core@REL1_38] TemplateParser: avoid warnings when called by NoLocalSettings.

https://gerrit.wikimedia.org/r/779872

Maintenance_bot removed a project: Patch-For-Review.Apr 13 2022, 7:30 PM
gerritbot added a project: Patch-For-Review.Apr 13 2022, 7:30 PM
gerritbot added a comment.Apr 13 2022, 7:32 PM

Change 779873 had a related patch set uploaded (by Reedy; author: Daniel Kinzler):

[mediawiki/core@REL1_37] TemplateParser: avoid warnings when called by NoLocalSettings.

https://gerrit.wikimedia.org/r/779873

gerritbot added a comment.Apr 13 2022, 7:32 PM

Change 779874 had a related patch set uploaded (by Reedy; author: Daniel Kinzler):

[mediawiki/core@REL1_36] TemplateParser: avoid warnings when called by NoLocalSettings.

https://gerrit.wikimedia.org/r/779874

gerritbot added a comment.Apr 13 2022, 7:32 PM

Change 779875 had a related patch set uploaded (by Reedy; author: Daniel Kinzler):

[mediawiki/core@REL1_35] TemplateParser: avoid warnings when called by NoLocalSettings.

https://gerrit.wikimedia.org/r/779875

Reedy renamed this task from LocalSettings.php is missing page gives deprecation warnings in REL1_38, and master to LocalSettings.php is missing page gives deprecation warnings.Apr 13 2022, 7:34 PM
Reedy added projects: MW-1.35-release, MW-1.36-release, MW-1.37-release.
gerritbot added a comment.Apr 13 2022, 7:58 PM

Change 779875 merged by jenkins-bot:

[mediawiki/core@REL1_35] TemplateParser: avoid warnings when called by NoLocalSettings.

https://gerrit.wikimedia.org/r/779875

gerritbot added a comment.Apr 13 2022, 7:59 PM

Change 779873 merged by jenkins-bot:

[mediawiki/core@REL1_37] TemplateParser: avoid warnings when called by NoLocalSettings.

https://gerrit.wikimedia.org/r/779873

gerritbot added a comment.Apr 13 2022, 7:59 PM

Change 779874 merged by jenkins-bot:

[mediawiki/core@REL1_36] TemplateParser: avoid warnings when called by NoLocalSettings.

https://gerrit.wikimedia.org/r/779874

gerritbot added a comment.Apr 13 2022, 7:59 PM

Change 779872 merged by jenkins-bot:

[mediawiki/core@REL1_38] TemplateParser: avoid warnings when called by NoLocalSettings.

https://gerrit.wikimedia.org/r/779872

ReleaseTaggerBot added projects: MW-1.36-notes, MW-1.38-notes, MW-1.35-notes, MW-1.37-notes.Apr 13 2022, 8:00 PM
Reedy closed this task as Resolved.Apr 13 2022, 8:26 PM
Reedy assigned this task to daniel.
Maintenance_bot removed a project: Patch-For-Review.Apr 13 2022, 8:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits