Page MenuHomePhabricator

Duplicate editing toolbar in Section Translation
Closed, ResolvedPublic

Description

In the test instance where the new Vue 3 version of Section Translation is available (T299622), editing shows a duplicate toolbar when editing the second time: first editing of the title works as expected, but editing the first sentence on the first text paragraph shows a duplicated toolbar.

I tested this when translating the "Ethymology" section of Paneer from English to Spanish (using the option to start the translation from scratch):

This issue is not occurring on Test Wikipedia where the code updated for the new Vue version is not present:

Test instance with Vue 3Test Wikipedia (Vue 2)
sx.wmflabs.org_index.php_title=Special_ContentTranslation&from=en&to=es(iPhone SE) (2).png (1×750 px, 53 KB)
test.m.wikipedia.org_w_index.php_title=Special_ContentTranslation&from=en&to=es&sx=true(iPhone SE) (1).png (1×750 px, 51 KB)

Event Timeline

Pginer-WMF created this task.
Pginer-WMF updated the task description. (Show Details)

Change 774429 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] SX VE: Clear the toolbar content when surface is destroyed

https://gerrit.wikimedia.org/r/774429

Change 774507 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20220328

https://gerrit.wikimedia.org/r/774507

Change 774429 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX VE: Clear the toolbar content when surface is destroyed

https://gerrit.wikimedia.org/r/774429

Change 774507 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20220328

https://gerrit.wikimedia.org/r/774507

Following the same steps, the toolbar does no longer show as duplicated:

sx.wmflabs.org_index.php_title=Special_ContentTranslation&title=Special%3AContentTranslation&from=en&to=es&sx=true&page=Paneer(iPhone SE).png (1×750 px, 51 KB)