PHP Notice: Undefined index: svg
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	hashar
	Mar 29 2022, 9:37 AM

Description

Error

mwversion: 1.39.0-wmf.5
reqId: 5be40ffd-5538-4e82-b81d-9ecd0aea487a
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Undefined index: svg

exception.trace

from /srv/mediawiki/php-1.39.0-wmf.5/skins/Timeless/includes/TimelessTemplate.php(535)
#0 /srv/mediawiki/php-1.39.0-wmf.5/skins/Timeless/includes/TimelessTemplate.php(535): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.39.0-wmf.5/skins/Timeless/includes/TimelessTemplate.php(86): MediaWiki\Skin\Timeless\TimelessTemplate->getLogo(string, string)
#2 /srv/mediawiki/php-1.39.0-wmf.5/includes/skins/SkinTemplate.php(135): MediaWiki\Skin\Timeless\TimelessTemplate->execute()
#3 /srv/mediawiki/php-1.39.0-wmf.5/includes/skins/SkinTemplate.php(150): SkinTemplate->generateHTML()
#4 /srv/mediawiki/php-1.39.0-wmf.5/includes/OutputPage.php(2808): SkinTemplate->outputPage()
#5 /srv/mediawiki/php-1.39.0-wmf.5/includes/MediaWiki.php(925): OutputPage->output(boolean)
#6 /srv/mediawiki/php-1.39.0-wmf.5/includes/MediaWiki.php(938): MediaWiki::{closure}()
#7 /srv/mediawiki/php-1.39.0-wmf.5/includes/MediaWiki.php(565): MediaWiki->main()
#8 /srv/mediawiki/php-1.39.0-wmf.5/index.php(53): MediaWiki->run()
#9 /srv/mediawiki/php-1.39.0-wmf.5/index.php(46): wfIndexMain()
#10 /srv/mediawiki/w/index.php(3): require(string)
#11 {main}

Impact

Notes

Reproducible by browsing mediawiki with the Timeless skin enabled https://www.mediawiki.org/wiki/Skin:MonoBook?useskin=timeless

Probably due to 5087e5781ebbfdc1f5006484c037c9b01affc50b Use svg for the logo if applicable

Details

Request URL: https://www.mediawiki.org/wiki/Skin:MonoBook?useskin=timeless

Subject	Repo	Branch	Lines +/-
Use null coalescing operator	mediawiki/skins/Timeless	wmf/1.39.0-wmf.5	+1 -1
Use null coalescing operator	mediawiki/skins/Timeless	master	+1 -1
Follow-up 5087e578: Handle undefined index svg	mediawiki/skins/Timeless	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	hashar	T300204 1.39.0-wmf.5 deployment blockers
		Resolved	PRODUCTION ERROR	Lucas_Werkmeister_WMDE	T304917 PHP Notice: Undefined index: svg

Event Timeline

hashar triaged this task as Unbreak Now! priority.Mar 29 2022, 9:37 AM

hashar created this task.

hashar added a parent task: T300204: 1.39.0-wmf.5 deployment blockers.

Change 774858 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/skins/Timeless@master] Use null coalescing operator

https://gerrit.wikimedia.org/r/774858

gerritbot added a project: Patch-For-Review.Mar 29 2022, 10:00 AM

In T304917#7813611, @gerritbot wrote:

Change 774858 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/skins/Timeless@master] Use null coalescing operator

https://gerrit.wikimedia.org/r/774858

Tested locally (the bug was reproducible with wfLoadSkin( 'Timeless' ), ?useskin=timeless, and no special configuration).

Change 774859 had a related patch set uploaded (by Func; author: Func):

[mediawiki/skins/Timeless@master] Follow-up 5087e578: Handle undefined index svg

https://gerrit.wikimedia.org/r/774859

Change 774859 abandoned by Func:

[mediawiki/skins/Timeless@master] Follow-up 5087e578: Handle undefined index svg

Reason:

conflicts

https://gerrit.wikimedia.org/r/774859

Change 774858 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Use null coalescing operator

https://gerrit.wikimedia.org/r/774858

Change 774833 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/skins/Timeless@wmf/1.39.0-wmf.5] Use null coalescing operator

https://gerrit.wikimedia.org/r/774833

Change 774833 merged by jenkins-bot:

[mediawiki/skins/Timeless@wmf/1.39.0-wmf.5] Use null coalescing operator

https://gerrit.wikimedia.org/r/774833

Mentioned in SAL (#wikimedia-operations) [2022-03-29T12:02:54Z] <hashar@deploy1002> Synchronized php-1.39.0-wmf.5/skins/Timeless/includes/TimelessTemplate.php: Use null coalescing operator - T304917 (duration: 06m 50s)

Tested on mwdebug and deployed live. Thank you!

Maintenance_bot removed a project: Patch-For-Review.Mar 29 2022, 12:10 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Mar 29 2022, 1:00 PM

Krinkle moved this task from Untriaged to Mar 2022 on the Wikimedia-production-error board.Apr 7 2022, 3:38 PM

PHP Notice: Undefined index: svgClosed, ResolvedPublicPRODUCTION ERRORActions