Page MenuHomePhabricator

Media player broken on Early adopters RTL wikis
Closed, ResolvedPublic

Event Timeline

Both work for me (Logged in, Firefox 98.0.2 on Windows 11).
Note that I'm seeing different players UI these pages.

commonswiki is also a group1 wiki. I would rather guess that this is due to T248418.

Also I don't really see what is broken (the ui looks weird, but playing audio works).

Edit: My hewiki view is not rtl, which explain why I didn't see the issue.

Hebrew wiki player:

image.png (92×642 px, 7 KB)

commons player:

image.png (74×618 px, 12 KB)

Happens on fa.wiki as well, but not on enwiki. Not an RTL issue, since test.wiki is also broken for me.

I get a blank/black video popup on hewiki. It plays the audio fine, but it looks ugly...

@Zabe you are probably correct. Wikis that got the rollout seem broken.

Found out It only works if you click the grey area, not if you click the super dark play icon.

Matanya renamed this task from Media player broken on group1 wikis to Media player broken on Early adopters.Mar 31 2022, 3:01 PM

This is an rtl issue with the CSS style line .mw-tmh-player.audio .mw-tmh-label.mw-tmh-duration, which has set left: 1em

Compare:
https://he.wikipedia.org/wiki/קובץ:Toccata_et_Fugue_BWV565.ogg?uselang=en
https://he.wikipedia.org/wiki/קובץ:Toccata_et_Fugue_BWV565.ogg?uselang=he

We will just have to 'noflip' that offset, as the control order is always in ltr order.

TheDJ triaged this task as High priority.Mar 31 2022, 3:08 PM
Matanya renamed this task from Media player broken on Early adopters to Media player broken on Early adopters RTL wikis.Mar 31 2022, 3:10 PM

Change 775897 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/TimedMediaHandler@master] Set noflip for css rule that needs it

https://gerrit.wikimedia.org/r/775897

We can just fallback to the default for the labels, which is already marked noflip. So amended as such

Change 775443 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/TimedMediaHandler@wmf/1.39.0-wmf.5] Set noflip for css rule that needs it

https://gerrit.wikimedia.org/r/775443

Change 775897 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Set noflip for css rule that needs it

https://gerrit.wikimedia.org/r/775897

Change 775443 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@wmf/1.39.0-wmf.5] Set noflip for css rule that needs it

https://gerrit.wikimedia.org/r/775443

Mentioned in SAL (#wikimedia-operations) [2022-03-31T18:23:07Z] <ladsgroup@deploy1002> Synchronized php-1.39.0-wmf.5/extensions/TimedMediaHandler/resources/ext.tmh.player.styles.less: Backport: [[gerrit:775443|Set noflip for css rule that needs it (T305156)]] (duration: 00m 51s)

Ladsgroup claimed this task.