Maniphest T306138

Remove poweredbyico SkinTemplate variable AND SkinGetPoweredBy hook
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The SkinGetPoweredBy hook was deprecated in 1.37
It's also added as a variable inside SkinTemplate like so:

// Run deprecated hook.
                $this->getHookRunner()->onSkinGetPoweredBy( $poweredBy, $this );
                $tpl->set( 'poweredbyico', $poweredBy );
                $tpl->deprecate( 'poweredbyico', '1.37' ); // [[phab:T290583]]

# acceptance criteria

[] remove the code
[] add to RELEASE NOTES under breaking change

Usages are non-existent and less likely given T305560 so let's remove:

Details

	Subject	Repo	Branch	Lines +/-
	Access to copyrightico is removed in 1.39	mediawiki/skins/Cavendish	master	+9 -3
	Remove poweredbyico SkinTemplate variable AND SkinGetPoweredBy hook	mediawiki/core	master	+6 -180
	Access to copyrightico is removed in 1.39	mediawiki/skins/webplatform	master	+7 -1

Customize query in gerrit

Related Objects

Mentioned In: rSCAVdf4a436762ea: Access to copyrightico is removed in 1.39
Mentioned Here: T305560: Remove Skin::getCopyrightIcon and Skin::getPoweredBy

Event Timeline

Jdlrobson created this task.Apr 13 2022, 9:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2022, 9:52 PM

Jdlrobson triaged this task as Medium priority.May 9 2022, 10:45 PM

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2021-22).

Jdlrobson added projects: good first task, patch-welcome.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson updated the task description. (Show Details)May 25 2022, 4:55 PM

LGoto set the point value for this task to 2.May 25 2022, 4:55 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Mabualruz changed the task status from Open to In Progress.Jun 2 2022, 5:33 PM

Mabualruz claimed this task.

Mabualruz moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 803516 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] Remove poweredbyico SkinTemplate variable AND SkinGetPoweredBy hook

https://gerrit.wikimedia.org/r/803516

gerritbot added a project: Patch-For-Review.Jun 7 2022, 1:54 PM

Mabualruz removed Mabualruz as the assignee of this task.Jun 7 2022, 2:02 PM

Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Mabualruz subscribed.

Jdlrobson claimed this task.Jun 7 2022, 5:03 PM

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 7 2022, 9:55 PM

Jdlrobson reassigned this task from Jdlrobson to Mabualruz.Jun 10 2022, 10:21 PM

Mabualruz removed Mabualruz as the assignee of this task.Jun 26 2022, 9:19 AM

Mabualruz moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 808929 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/webplatform@master] Access to copyrightico is removed in 1.39

https://gerrit.wikimedia.org/r/808929

Change 808930 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Cavendish@master] Access to copyrightico is removed in 1.39

https://gerrit.wikimedia.org/r/808930

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 27 2022, 3:55 PM

Change 808929 merged by jenkins-bot:

[mediawiki/skins/webplatform@master] Access to copyrightico is removed in 1.39

https://gerrit.wikimedia.org/r/808929

Mabualruz claimed this task.Jun 28 2022, 3:17 PM

Mabualruz removed Mabualruz as the assignee of this task.

Mabualruz moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson claimed this task.Jun 28 2022, 5:18 PM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 28 2022, 10:45 PM

This can skip QA. Sign off = making sure all traces of the code are gone from codesearch.

Change 803516 merged by jenkins-bot:

[mediawiki/core@master] Remove poweredbyico SkinTemplate variable AND SkinGetPoweredBy hook

https://gerrit.wikimedia.org/r/803516

Only remaining instance is naumenko / GMW-Free-Skin (which is commented out so a false positive) and release notes. Thanks Mo!

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 11 2022, 8:02 PM

Change 808930 merged by Jdlrobson:

[mediawiki/skins/Cavendish@master] Access to copyrightico is removed in 1.39

https://gerrit.wikimedia.org/r/808930

Maintenance_bot removed a project: Patch-For-Review.Jul 26 2022, 10:31 AM

Jdlrobson mentioned this in rSCAVdf4a436762ea: Access to copyrightico is removed in 1.39.Jul 26 2022, 11:51 AM