RelatedArticles should be limited to ES6 browsers
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 18 2022, 4:14 PM

Description

RelatedArticles currently requires support for IntersectionObserver which is supported on Edge >= 16, Firefox >55, Chrome >58, Safari 12.1, Opera >=38, iOS Safari >=12.2, Android 100

Full ES6 is supported in Edge >=15, Firefox >=54, Chrome >=51, Safari >=10, Opera >=38, iOS Safari >=10, so such a change would only drop support for Edge 15 and Firefox 54.

Additionally we ship a shim for CSS API to access the method CSS.escape. This is guaranteed in all these browsers according to caniuse, with the only discrepancy being the Edge browser (versions
16-18) so it is also suggested we remove support for those browsers.

Firefox 54 accounts for 0.0026% of page views
Edge 15-18 accounts for 0.069% of page views

Acceptance criteria

Limit feature to ES6, dropping support for Edge 15-18 and Firefox 54
Remove the CSS shim

Details

	Subject	Repo	Branch	Lines +/-
	Limit RelatedArticles feature to ES6 browsers	mediawiki/extensions/RelatedArticles	master	+45 -177

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T284951 [EPIC] Simplify the RelatedArticles extension
		Resolved		Jdlrobson	T306355 RelatedArticles should be limited to ES6 browsers

Event Timeline

Jdlrobson created this task.Apr 18 2022, 4:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2022, 4:14 PM

Change 781084 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/RelatedArticles@master] Limit RelatedArticles feature to ES6 browsers

https://gerrit.wikimedia.org/r/781084

gerritbot added a project: Patch-For-Review.Apr 18 2022, 4:14 PM

Jdlrobson added a project: RelatedArticles.Apr 19 2022, 3:50 PM

Jdlrobson mentioned this in T306228: Reduce RelatedArticles to two ResourceLoader modules.

Jdlrobson added a parent task: T284951: [EPIC] Simplify the RelatedArticles extension.Apr 19 2022, 3:55 PM

Jdlrobson moved this task from Future Unplanned to RelatedArticles cleanup on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Apr 19 2022, 4:49 PM

Just leaving a note confirming these pageviews are low enough to warrant removal

Change 781084 merged by jenkins-bot:

[mediawiki/extensions/RelatedArticles@master] Limit RelatedArticles feature to ES6 browsers

https://gerrit.wikimedia.org/r/781084

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).Apr 27 2022, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2022, 5:30 PM

I verified that related cards still show on the beta cluster:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Related_test

Screen Shot 2022-04-27 at 3.05.38 PM.png (606×2 px, 253 KB)

On Edge 15 these do not show as expected:

Screen Shot 2022-04-27 at 3.06.13 PM.png (944×2 px, 640 KB)

Note there is an empty space but that appears to already be a problem in production.

Also confirmed Edge 16 is working in production but not on https://en.m.wikipedia.beta.wmflabs.org/wiki/Related_test after this patch as expected:

Screen Shot 2022-04-27 at 3.08.11 PM.png (628×2 px, 347 KB)

	F35070973: Screen Shot 2022-04-27 at 3.08.11 PM.png
	Apr 27 2022, 10:08 PM

	F35070968: Screen Shot 2022-04-27 at 3.06.13 PM.png
	Apr 27 2022, 10:08 PM

	F35070966: Screen Shot 2022-04-27 at 3.05.38 PM.png
	Apr 27 2022, 10:08 PM

RelatedArticles should be limited to ES6 browsersClosed, ResolvedPublicActions