Page MenuHomePhabricator

RelatedArticles should be limited to ES6 browsers
Closed, ResolvedPublic


RelatedArticles currently requires support for IntersectionObserver which is supported on Edge >= 16, Firefox >55, Chrome >58, Safari 12.1, Opera >=38, iOS Safari >=12.2, Android 100

Full ES6 is supported in Edge >=15, Firefox >=54, Chrome >=51, Safari >=10, Opera >=38, iOS Safari >=10, so such a change would only drop support for Edge 15 and Firefox 54.

Additionally we ship a shim for CSS API to access the method CSS.escape. This is guaranteed in all these browsers according to caniuse, with the only discrepancy being the Edge browser (versions
16-18) so it is also suggested we remove support for those browsers.

Firefox 54 accounts for 0.0026% of page views
Edge 15-18 accounts for 0.069% of page views

Acceptance criteria

  • Limit feature to ES6, dropping support for Edge 15-18 and Firefox 54
  • Remove the CSS shim

Event Timeline

Change 781084 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/RelatedArticles@master] Limit RelatedArticles feature to ES6 browsers

Just leaving a note confirming these pageviews are low enough to warrant removal

Change 781084 merged by jenkins-bot:

[mediawiki/extensions/RelatedArticles@master] Limit RelatedArticles feature to ES6 browsers

Jdlrobson claimed this task.

I verified that related cards still show on the beta cluster:

Screen Shot 2022-04-27 at 3.05.38 PM.png (606×2 px, 253 KB)

On Edge 15 these do not show as expected:

Screen Shot 2022-04-27 at 3.06.13 PM.png (944×2 px, 640 KB)

Note there is an empty space but that appears to already be a problem in production.

Also confirmed Edge 16 is working in production but not on after this patch as expected:

Screen Shot 2022-04-27 at 3.08.11 PM.png (628×2 px, 347 KB)