Page MenuHomePhabricator
Create Task
Maniphest T306228

Reduce RelatedArticles to two ResourceLoader modules
Closed, ResolvedPublic
Actions

Description

Several changes are proposed to reduce the number of ResourceLoader modules in RelatedArticles. Historically most of these modules exist to support testing, implemented long before the packageFiles construct.

  • Merge the ext.relatedArticles.readMore and ext.relatedArticles.cards modules. Both modules are always loaded together. This was initially flagged by @phuedx during another maintenance change.
  • Merge ext.relatedArticles.readMore.gateway module into ext.relatedArticles.readMore.bootstrap
  • Drop the unnecessary OO dependency on the RelatedArticlesGateway

Details

SubjectRepoBranchLines +/-
[organization] organize file by modulemediawiki/extensions/RelatedArticlesmaster+18 -18
[Maintenance] Reduce related articles to two modulesmediawiki/extensions/RelatedArticlesmaster+298 -343
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Apr 14 2022, 11:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2022, 11:32 PM
gerritbot added a comment.Apr 14 2022, 11:33 PM

Change 781076 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/RelatedArticles@master] [Maintenance] Reduce related articles to two modules

https://gerrit.wikimedia.org/r/781076

gerritbot added a project: Patch-For-Review.Apr 14 2022, 11:33 PM
gerritbot added a comment.Apr 14 2022, 11:45 PM

Change 781084 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/RelatedArticles@master] Limit RelatedArticles feature to ES6 browsers

https://gerrit.wikimedia.org/r/781084

Jdlrobson updated the task description. (Show Details)Apr 14 2022, 11:47 PM
gerritbot added a comment.Apr 15 2022, 12:51 AM

Change 781112 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/RelatedArticles@master] [organization] organize file by module

https://gerrit.wikimedia.org/r/781112

gerritbot added a comment.Apr 17 2022, 8:22 PM

Change 781076 merged by jenkins-bot:

[mediawiki/extensions/RelatedArticles@master] [Maintenance] Reduce related articles to two modules

https://gerrit.wikimedia.org/r/781076

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).Apr 17 2022, 8:25 PM
gerritbot added a comment.Apr 18 2022, 4:00 PM

Change 781112 merged by jenkins-bot:

[mediawiki/extensions/RelatedArticles@master] [organization] organize file by module

https://gerrit.wikimedia.org/r/781112

Jdlrobson updated the task description. (Show Details)Apr 19 2022, 3:50 PM

Remove A/C as I created T306355 for ES6.

Jdlrobson closed this task as Resolved.Apr 19 2022, 3:51 PM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog (Needs Prioritization (Tech)).
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a parent task: T284951: [EPIC] Simplify the RelatedArticles extension.Apr 19 2022, 3:55 PM
phuedx awarded a token.Apr 25 2022, 9:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL