Page MenuHomePhabricator

infobox may not work on all installs; add mediawiki.storage dependency to extension.json
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

What is the problem?

On my local docker install of IPInfo, the infobox does not work. Instead, I get a javascript error:

TypeError: mw.storage is undefined.

According to @DLynch, the extension.json file is missing the dependency on mediawiki.storage.

For the production environment, this does not seem to make a difference as other extensions include mediawiki.storage instead.

However, if you install IPInfo in an environment where mediawiki.storage is not already being included by other extensions, the infobox won't work.

Event Timeline

AGueyte set the point value for this task to 1.May 2 2022, 5:25 PM

Change 789100 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/IPInfo@master] add mediawiki.storage dependency to extension.json

https://gerrit.wikimedia.org/r/789100

Change 789100 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] add mediawiki.storage dependency to extension.json

https://gerrit.wikimedia.org/r/789100

I created a completely fresh local docker MediaWiki install which had no extensions. On it, I successfully installed IPInfo. The infobox worked.

Test environment: local docker IP Info 0.0.0 (a3b1302) 09:00, 4 May 2022.