Page MenuHomePhabricator

Scream bloody murder when user chooses MyISAM and InnoDB is available
Closed, ResolvedPublic

Description

We live in new shiny 3rd millenium, yet MyISAM doesn't support transactions causing lulz like bug 28611; it's also more prone to corruption. To prevent users from making the mistake of choosing MyISAM, we should warn them sternly, just explaining it in help is not enough.


Version: 1.18.x
Severity: enhancement

Details

Reference
bz28669

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:37 PM
bzimport set Reference to bz28669.
bzimport added a subscriber: Unknown Object (MLST).

We have special code in the main classes for manually rollbacking changes in MyISAM (ugly! ugly!). But most of our codebase doesn't take caution for a transactionless db, so there are probably many places which could go wrong with MyISAM nowadays.

wsd wrote:

Patch for this bug

Here's a patch to have the installer "scream bloody murder." I think it addresses the concerns raised.

Attached:

-need-review+reviewed since mah would of checked it over before applying to trunk.

(In reply to comment #4)

-need-review+reviewed since mah would of checked it over before applying to
trunk.

and other people made follow-up commits for the things I missed.