Page MenuHomePhabricator
Create Task
Maniphest T307492

Incorrect height of class "phui-oi-frame"
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Click the caret symbol at the right of avatar, check the menu

What happens?:
Avatar inside menu shown incompletely.

What should have happened instead?:
It should looks normal.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
I know this is actually an upstream issue, but as Phabricator has announced that "Phabricator is no longer actively maintained" since 2021-06-01, I think it is fine to fill a local task.

Related Objects
Search...

Event Timeline

Stang created this task.May 3 2022, 6:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2022, 6:09 PM
Stang claimed this task.May 3 2022, 6:09 PM
Stang updated the task description. (Show Details)
Stang unsubscribed.
Stang removed Stang as the assignee of this task.May 3 2022, 6:30 PM
Stang subscribed.

Seems I could not push changes for review in repo phabricator/phabricator..

diff --git a/webroot/rsrc/css/phui/object-item/phui-oi-simple-ui.css b/webroot/rsrc/css/phui/object-item/phui-oi-simple-ui.css
index e838f1ce3e..fcf2e7ad1b 100644
--- a/webroot/rsrc/css/phui/object-item/phui-oi-simple-ui.css
+++ b/webroot/rsrc/css/phui/object-item/phui-oi-simple-ui.css
@@ -4,7 +4,7 @@
  */
 
 .phui-oi-list-simple .phui-oi-with-image .phui-oi-frame {
-  min-height: 26px;
+  min-height: 36px;
 }
 
 .phui-oi-list-simple .phui-oi-image {
Peachey88 edited projects, added Phabricator (Upstream); removed Phabricator.May 8 2022, 8:59 AM
Maintenance_bot added a project: Upstream.May 8 2022, 9:29 AM
Aklapper changed the task status from Open to Stalled.Jul 13 2023, 6:01 PM

Avatar inside menu shown incompletely.

@Stang: Is this still an issue? Could you attach a screenshot please?

+ min-height: 36px;

Cannot reproduce; that's exactly what it already says here:

Screenshot from 2023-07-13.png (603×1 px, 155 KB)

Stang added a comment.EditedJul 13 2023, 7:43 PM

@Aklapper

image.png (590×483 px, 41 KB)

The issue is that if you don't specify a "also known as" in your profile, the height of div "phui-oi-frame" does not have enough height to display a full avatar

Aklapper changed the task status from Stalled to Open.Jul 14 2023, 8:51 AM
Aklapper moved this task from Backlog to Upstreamed on the Phabricator (Upstream) board.

Ahhhh! Nice catch! I can reproduce. Upstreamed as https://we.phorge.it/T15552

Aklapper moved this task from Backlog to Reported Upstream on the Upstream board.Jul 14 2023, 8:51 AM
Aklapper claimed this task.Jul 14 2023, 9:37 AM
Aklapper triaged this task as Low priority.
Aklapper added a project: CSS.
Aklapper moved this task from Reported Upstream to Patch proposed upstream on the Upstream board.
Aklapper changed the task status from Open to Stalled.Jul 17 2023, 10:04 AM
Aklapper moved this task from Patch proposed upstream to Patch merged upstream on the Upstream board.
Aklapper edited projects, added Phabricator (2023-08-23); removed Phabricator (Upstream).
Aklapper moved this task from 2023-08-23 to 2023-10-03 on the Phabricator board.Aug 23 2023, 3:31 PM
Aklapper edited projects, added Phabricator (2023-10-03); removed Phabricator (2023-08-23).
Aklapper moved this task from 2023-10-03 to 2023-10-17 on the Phabricator board.Oct 3 2023, 3:22 PM
Aklapper edited projects, added Phabricator (2023-10-17); removed Phabricator (2023-10-03).
• brennen moved this task from 2023-10-17 to 2023-11-14 on the Phabricator board.Oct 16 2023, 10:06 PM
• brennen edited projects, added Phabricator (2023-11-14); removed Phabricator (2023-10-17).
Aklapper edited projects, added Phabricator (Upstream); removed Phabricator (2023-11-14).Nov 9 2023, 4:50 PM

[Move tasks resolved in upstream from #phabricator-next (as not every deployment will also pull an updated upstream) to the "Solved upstream" column on the Phabricator (Upstream) workboard]

Aklapper moved this task from Upstreamed to Solved upstream on the Phabricator (Upstream) board.Nov 9 2023, 4:51 PM
Izno moved this task from Backlog to Change CSS on the CSS board.Feb 1 2024, 2:49 AM
Aklapper added a subtask: T358610: Update wmf/stable to Phorge upstream's 2023.49 stable release.Mar 17 2024, 4:39 PM
Aklapper closed this task as Resolved.Mar 21 2024, 3:29 PM

This issue should be resolved in phabricator.wikimedia.org since 2024-03-19 thanks to brennen's deployment in T358610. Please reopen if you still experience this issue.

Aklapper closed subtask T358610: Update wmf/stable to Phorge upstream's 2023.49 stable release as Resolved.Mar 21 2024, 8:04 PM
Stang unsubscribed.Oct 24 2024, 3:43 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits