Page MenuHomePhabricator
Create Task
Maniphest T308044

Remove reference to Elastica\Type from CirrusSearch and related extensions and upgrade to Elastica 7.1.5
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

The class Elastica\Type is being removed from Elastica so we should stop using it.

  • remove references to Elastica\Type from all supported MW extensions
  • upgrade mediawiki-vendor to depend on Elastica 7.1.5
  • upgrade the MW Elastica extension to depend on Elastica 7.1.5

Notes:

  • production and CI is still running against PHP 7.2 (elasticsearch/elasticsearch v7.11.0 must be forced because this is the last version explicitly supporting this version)

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

• dcausse created this task.May 10 2022, 5:24 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMay 10 2022, 5:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.May 10 2022, 5:43 PM

Change 790731 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/WikibaseCirrusSearch@master] Remove reference to Elastica\Type

https://gerrit.wikimedia.org/r/790731

gerritbot added a project: Patch-For-Review.May 10 2022, 5:43 PM

Change 790732 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/GeoData@master] Remove reference to Elastica\Type

https://gerrit.wikimedia.org/r/790732

gerritbot added a comment.May 10 2022, 5:56 PM

Change 790734 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/CirrusSearch@master] [WIP] First pass at removing obvious Type usages

https://gerrit.wikimedia.org/r/790734

gerritbot added a comment.May 11 2022, 8:58 AM

Change 790988 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/Wikibase@master] Fix cirrussearch stubs

https://gerrit.wikimedia.org/r/790988

gerritbot added a comment.May 13 2022, 3:55 PM

Change 791634 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/vendor@master] Upgrade to Elastica 7.1.5

https://gerrit.wikimedia.org/r/791634

gerritbot added a comment.May 13 2022, 3:59 PM

Change 791407 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/CirrusSearch@master] [WIP] Migrate to Elastica 7.1.5

https://gerrit.wikimedia.org/r/791407

gerritbot added a comment.May 13 2022, 4:53 PM

Change 790731 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Remove reference to Elastica\Type

https://gerrit.wikimedia.org/r/790731

gerritbot added a comment.May 13 2022, 4:53 PM

Change 790734 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] First pass at removing obvious Type usages

https://gerrit.wikimedia.org/r/790734

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 14 2022, 4:00 AM
gerritbot added a comment.May 16 2022, 8:34 AM

Change 791406 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/Elastica@master] [WIP] Switch to Elastica 7.1.5

https://gerrit.wikimedia.org/r/791406

• dcausse renamed this task from Remove reference to Elastica\Type from CirrusSearch and related extensions to Remove reference to Elastica\Type from CirrusSearch and related extensions and upgrade to Elastica 7.1.5.May 16 2022, 8:38 AM
• dcausse updated the task description. (Show Details)
gerritbot added a comment.May 16 2022, 9:12 AM

Change 792114 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/CirrusSearch@es710] Migrate to Elastica 7.1.5

https://gerrit.wikimedia.org/r/792114

gerritbot added a comment.May 16 2022, 9:12 AM

Change 791407 abandoned by DCausse:

[mediawiki/extensions/CirrusSearch@master] [WIP] Migrate to Elastica 7.1.5

Reason:

moved to the es710 branch

https://gerrit.wikimedia.org/r/791407

Gehel moved this task from needs triage to Current work on the Discovery-Search board.May 16 2022, 3:18 PM
Gehel edited projects, added Discovery-Search (Current work); removed Discovery-Search.
Gehel set the point value for this task to 5.May 16 2022, 3:29 PM
Gehel moved this task from Incoming to In Progress on the Discovery-Search (Current work) board.
gerritbot added a comment.May 17 2022, 10:11 AM

Change 790732 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Remove reference to Elastica\Type

https://gerrit.wikimedia.org/r/790732

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.13; 2022-05-23); removed MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 17 2022, 6:00 PM
gerritbot added a comment.May 18 2022, 8:43 AM

Change 792652 had a related patch set uploaded (by Ladsgroup; author: DCausse):

[mediawiki/extensions/GeoData@wmf/1.39.0-wmf.12] Remove reference to Elastica\Type

https://gerrit.wikimedia.org/r/792652

gerritbot added a comment.May 18 2022, 9:04 AM

Change 792652 merged by jenkins-bot:

[mediawiki/extensions/GeoData@wmf/1.39.0-wmf.12] Remove reference to Elastica\Type

https://gerrit.wikimedia.org/r/792652

Stashbot added a comment.May 18 2022, 9:06 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-18T09:06:45Z] <ladsgroup@deploy1002> Synchronized php-1.39.0-wmf.12/extensions/GeoData/includes/Searcher.php: Backport: [[gerrit:792652|Remove reference to Elastica\Type (T308044)]] (duration: 00m 52s)

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.12; 2022-05-16); removed MW-1.39-notes (1.39.0-wmf.13; 2022-05-23).May 18 2022, 5:00 PM
EBernhardson moved this task from In Progress to Needs review on the Discovery-Search (Current work) board.May 23 2022, 3:21 PM
gerritbot added a comment.May 25 2022, 8:47 PM

Change 790988 abandoned by Ebernhardson:

[mediawiki/extensions/Wikibase@master] Fix cirrussearch stubs

Reason:

I9ea6a539f2a2e438584436fef7ce464314d9dcea changed wikibase to clone dependencies instead of using stubs, this is no longer necessary.

https://gerrit.wikimedia.org/r/790988

• dcausse added a subtask: T309581: Translate should be compatible with ruflin/Elastica 7.1.5.May 31 2022, 7:32 AM
Daimona subscribed.Jun 4 2022, 3:47 PM
gerritbot added a comment.Aug 16 2022, 7:39 PM

Change 823717 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/vendor@es7] Set branch to es7

https://gerrit.wikimedia.org/r/823717

gerritbot added a comment.Aug 16 2022, 9:10 PM

Change 823736 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/vendor@es7] Upgrade to Elastica 7.11.0

https://gerrit.wikimedia.org/r/823736

gerritbot added a comment.Aug 16 2022, 10:15 PM

Change 823717 abandoned by Ebernhardson:

[mediawiki/vendor@es7] Set branch to es7

Reason:

branch must be es710, not es7, to match the extension repositories

https://gerrit.wikimedia.org/r/823717

gerritbot added a comment.Aug 16 2022, 10:16 PM

Change 823736 abandoned by Ebernhardson:

[mediawiki/vendor@es7] Upgrade to Elastica 7.1.5

Reason:

branch must be es710, not es7, to match the extension repositories

https://gerrit.wikimedia.org/r/823736

gerritbot added a comment.Aug 16 2022, 10:16 PM

Change 823760 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/vendor@es710] Set branch to es710

https://gerrit.wikimedia.org/r/823760

gerritbot added a comment.Aug 16 2022, 10:16 PM

Change 823761 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/vendor@es710] Upgrade to Elastica 7.1.5

https://gerrit.wikimedia.org/r/823761

gerritbot added a comment.Aug 16 2022, 10:18 PM

Change 791634 abandoned by Ebernhardson:

[mediawiki/vendor@master] Upgrade to Elastica 7.11.0

Reason:

supserseded by I960c480fb83014b48116d9ece4f6473b647110e9. Vendor will be merged into a branch to allow cross-repo CI testing prior to full
production deployment.

https://gerrit.wikimedia.org/r/791634

gerritbot added a comment.Aug 17 2022, 6:38 PM

Change 823760 merged by Ebernhardson:

[mediawiki/vendor@es710] Set branch to es710

https://gerrit.wikimedia.org/r/823760

gerritbot added a comment.Aug 17 2022, 6:39 PM

Change 823761 merged by Ebernhardson:

[mediawiki/vendor@es710] Upgrade to Elastica 7.1.5

https://gerrit.wikimedia.org/r/823761

gerritbot added a comment.Aug 17 2022, 7:35 PM

Change 791406 merged by jenkins-bot:

[mediawiki/extensions/Elastica@master] Switch to Elastica 7.1.5

https://gerrit.wikimedia.org/r/791406

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.26; 2022-08-22); removed MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).Aug 17 2022, 8:00 PM
gerritbot added a comment.Aug 17 2022, 11:03 PM

Change 792114 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@es710] Migrate to Elastica 7.1.5

https://gerrit.wikimedia.org/r/792114

EBernhardson moved this task from Needs review to To Be Deployed on the Discovery-Search (Current work) board.Aug 22 2022, 3:19 PM
EBernhardson edited projects, added MW-1.39-notes (1.39.0-wmf.12; 2022-05-16); removed MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review.Aug 22 2022, 5:33 PM
EBernhardson moved this task from To Be Deployed to Needs Reporting on the Discovery-Search (Current work) board.
EBernhardson subscribed.

afaict there are no more patches to review here. The re-tagging to wmf.26 was mistaken, the merge to Elastica master branch was supposed to be merged to es710 branch. The master branch change was reverted.

gerritbot added a comment.Aug 29 2022, 6:47 PM

Change 827544 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/vendor@master] Upgrade to Elastica 7.1.5

https://gerrit.wikimedia.org/r/827544

gerritbot added a project: Patch-For-Review.Aug 29 2022, 6:47 PM
Gehel closed this task as Resolved.Aug 30 2022, 6:39 PM
Gehel claimed this task.
gerritbot added a comment.Aug 30 2022, 8:37 PM

Change 827544 merged by Ebernhardson:

[mediawiki/vendor@master] Upgrade to Elastica 7.1.5

https://gerrit.wikimedia.org/r/827544

Gehel closed subtask T309581: Translate should be compatible with ruflin/Elastica 7.1.5 as Resolved.Sep 16 2022, 8:45 PM
hashar mentioned this in T318356: ApiFeatureUsage Error: Call to undefined method Elastica\Search::addType().Sep 22 2022, 3:47 PM
hashar added a subtask: T318356: ApiFeatureUsage Error: Call to undefined method Elastica\Search::addType().
hashar subscribed.

We have found ApiFeatureUsage could use a migration T318356

hashar closed subtask T318356: ApiFeatureUsage Error: Call to undefined method Elastica\Search::addType() as Resolved.Sep 23 2022, 1:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits