Page MenuHomePhabricator

CI Error: count(): Parameter must be an array or an object that implements Countable
Closed, ResolvedPublic

Description

This is currently blocking CI of extensions that run the WBQC phpunit test suite. Seems to be caused by a recent change in core.

Example for a failing job: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/150921/console

There were 4 errors:

1) WikibaseQuality\ConstraintReport\Tests\ConstraintRepositoryLookupTest::testQueryConstraintsForExistingProperty
count(): Parameter must be an array or an object that implements Countable

/var/www/html/w/includes/libs/rdbms/loadbalancer/LoadBalancer.php:1506
/var/www/html/w/includes/libs/rdbms/loadbalancer/LoadBalancer.php:519
/var/www/html/w/includes/libs/rdbms/loadbalancer/LoadBalancer.php:496
/var/www/html/w/includes/libs/rdbms/loadbalancer/LoadBalancer.php:929
/var/www/html/w/includes/libs/rdbms/database/DBConnRef.php:65
/var/www/html/w/includes/libs/rdbms/database/DBConnRef.php:277
/var/www/html/w/extensions/WikibaseQualityConstraints/src/ConstraintRepositoryLookup.php:45
/var/www/html/w/extensions/WikibaseQualityConstraints/tests/phpunit/ConstraintRepositoryLookupTest.php:33
/var/www/html/w/tests/phpunit/MediaWikiIntegrationTestCase.php:467

[... 3 more similar errors]

Event Timeline

kostajh triaged this task as Unbreak Now! priority.May 12 2022, 8:19 AM
kostajh subscribed.

Blocking merges to GrowthExperiments (and presumably lots of other repos) so marking as unbreak now.

Change 791304 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FakeLoadBalancer: Override getConnectionInternal

https://gerrit.wikimedia.org/r/791304

Change 791304 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FakeLoadBalancer: Override getConnectionInternal

https://gerrit.wikimedia.org/r/791304

Change 791326 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Kosta Harlan):

[mediawiki/extensions/Wikibase@master] phan: Remove stubs in favor of cloning dependencies in CI

https://gerrit.wikimedia.org/r/791326

Change 791326 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] phan: Remove stubs in favor of cloning dependencies in CI

https://gerrit.wikimedia.org/r/791326

Lucas_Werkmeister_WMDE assigned this task to Jakob_WMDE.

Fixed (UBN was already resolved with the first change, I’d say).