Followup PR feedback for adding Other filter
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tsevener
	May 16 2022, 11:47 PM

Description

This task is refactor some of the filter logic that snuck its way into RemoteNotificationType into its own RemoteNotificationFilterType enum, for clearer separation in the codebase.

See comment:

https://github.com/wikimedia/wikipedia-ios/pull/4217#discussion_r872555817

Notes for QA

Regression test Notifications filters

Event Timeline

Tsevener created this task.May 16 2022, 11:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 16 2022, 11:47 PM

Tsevener renamed this task from Followup PR Feedback for adding Other filter to Followup PR feedback for adding Other filter.May 16 2022, 11:48 PM

Tsevener assigned this task to Mazevedo.

Tsevener updated the task description. (Show Details)

Mazevedo moved this task from Tasks from Product Backlog to Doing on the iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon board.May 17 2022, 7:36 PM

PR https://github.com/wikimedia/wikipedia-ios/pull/4225

LGoto triaged this task as Medium priority.May 23 2022, 6:33 PM

LGoto moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.

Tsevener moved this task from Needs Code Review to Needs QA on the iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon board.May 26 2022, 10:05 PM

Tsevener updated the task description. (Show Details)

Looking good on 6.9.2 (1933)

Tsevener closed this task as Resolved.Jun 23 2022, 9:28 PM

Followup PR feedback for adding Other filterClosed, ResolvedPublicActions

Description

Notes for QA

Event Timeline

Followup PR feedback for adding Other filter
Closed, ResolvedPublic
Actions