Page MenuHomePhabricator

HIDPI support for logos among Chinese projects
Closed, ResolvedPublic

Description

Some Chinese Wikimedia projects already have HIDPI support for their logos, but those SVG files (stores on Wikimedia Commons) used to generate relevant PNG files are not noted inside logos/config.yaml, and this task aims to do so. There should be no identifiable changes to logo files.

This task also includes size adjustment for wordmark, adding logo variants into wmgSiteLogoVariants (similar to what we done in T273578). After this task is closed, all logos mentioned below should appear on page Commons:Auto-protected_files/misc/logos (maintained by KrinkleBot)

Project includes:

Details

SubjectRepoBranchLines +/-
operations/mediawiki-configmaster+309 -158
operations/mediawiki-configmaster+89 -1
operations/mediawiki-configmaster+32 -0
operations/mediawiki-configmaster+0 -5
operations/mediawiki-configmaster+5 -0
operations/mediawiki-configmaster+0 -13
operations/mediawiki-configmaster+47 -3
operations/mediawiki-configmaster+13 -0
operations/mediawiki-configmaster+3 -47
operations/mediawiki-configmaster+35 -3
operations/mediawiki-configmaster+1 -45
operations/mediawiki-configmaster+13 -0
operations/mediawiki-configmaster+5 -0
operations/mediawiki-configmaster+30 -2
operations/mediawiki-configmaster+0 -0
operations/mediawiki-configmaster+6 -45
operations/mediawiki-configmaster+24 -2
operations/mediawiki-configmaster+9 -7
operations/mediawiki-configmaster+0 -0
operations/mediawiki-configmaster+55 -78
operations/mediawiki-configmaster+0 -0
operations/mediawiki-configmaster+7 -6
operations/mediawiki-configmaster+0 -0
operations/mediawiki-configmaster+9 -3
operations/mediawiki-configmaster+0 -0
operations/mediawiki-configmaster+9 -5
operations/mediawiki-configmaster+7 -5
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 793027 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] zhwikivoyage: Declare commons files for logo and its variant

https://gerrit.wikimedia.org/r/793027

Change 793033 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] zhwiktionary: Declare commons files for logo

https://gerrit.wikimedia.org/r/793033

Change 793033 merged by jenkins-bot:

[operations/mediawiki-config@master] zhwiktionary: Declare commons files for logo

https://gerrit.wikimedia.org/r/793033

Mentioned in SAL (#wikimedia-operations) [2022-05-18T20:10:33Z] <cjming@deploy1002> Synchronized static/images/project-logos/zhwiktionary-1.5x.png: Config: [[gerrit:793033|zhwiktionary: Declare commons files for logo (T308620)]] (duration: 00m 52s)

Mentioned in SAL (#wikimedia-operations) [2022-05-18T20:11:31Z] <cjming@deploy1002> Synchronized static/images/project-logos/zhwiktionary-2x.png: Config: [[gerrit:793033|zhwiktionary: Declare commons files for logo (T308620)]] (duration: 00m 52s)

Mentioned in SAL (#wikimedia-operations) [2022-05-18T20:12:26Z] <cjming@deploy1002> Synchronized static/images/project-logos/zhwiktionary.png: Config: [[gerrit:793033|zhwiktionary: Declare commons files for logo (T308620)]] (duration: 00m 52s)

Mentioned in SAL (#wikimedia-operations) [2022-05-18T20:13:24Z] <cjming@deploy1002> Synchronized logos/config.yaml: Config: [[gerrit:793033|zhwiktionary: Declare commons files for logo (T308620)]] (duration: 00m 51s)

Mentioned in SAL (#wikimedia-operations) [2022-05-18T20:14:28Z] <cjming@deploy1002> Synchronized wmf-config/logos.php: Config: [[gerrit:793033|zhwiktionary: Declare commons files for logo (T308620)]] (duration: 00m 51s)

Change 793119 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] zhwikiquote: Optimize logo per commons files

https://gerrit.wikimedia.org/r/793119

Change 793125 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] zhwikivoyage: Generate zh-hant logo variant

https://gerrit.wikimedia.org/r/793125

Change 793127 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] zhwikisource: Optimize logo per commons files

https://gerrit.wikimedia.org/r/793127

Change 793128 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] zhwikiversity: Optimize logo per commons files

https://gerrit.wikimedia.org/r/793128

Change 792748 merged by jenkins-bot:

[operations/mediawiki-config@master] zhwikiquote: Declare commons files for logo and its variant

https://gerrit.wikimedia.org/r/792748

Change 793119 merged by jenkins-bot:

[operations/mediawiki-config@master] zhwikiquote: Optimize logo per commons files

https://gerrit.wikimedia.org/r/793119

Mentioned in SAL (#wikimedia-operations) [2022-05-19T14:20:06Z] <tgr@deploy1002> Synchronized static/images/project-logos: Config: [[gerrit:793119|zhwikiquote: Optimize logo per commons files (T308620)]] (duration: 00m 50s)

Change 792985 merged by jenkins-bot:

[operations/mediawiki-config@master] zhwikiversity: Declare commons files for logo and its variant

https://gerrit.wikimedia.org/r/792985

Mentioned in SAL (#wikimedia-operations) [2022-05-19T20:33:20Z] <bking@deploy1002> Synchronized wmf-config/logos.php: Config: [[gerrit:792985|zhwikiversity: Declare commons files for logo and its variant (T308620)]] (duration: 00m 53s)

Mentioned in SAL (#wikimedia-operations) [2022-05-19T20:34:25Z] <bking@deploy1002> Synchronized logos/config.yaml: Config: [[gerrit:792985|zhwikiversity: Declare commons files for logo and its variant (T308620)]] (duration: 00m 50s)

Change 793128 merged by jenkins-bot:

[operations/mediawiki-config@master] zhwikiversity: Optimize logo per commons files

https://gerrit.wikimedia.org/r/793128

Mentioned in SAL (#wikimedia-operations) [2022-05-19T20:40:44Z] <bking@deploy1002> Synchronized static/images/project-logos: Config: [[gerrit:793128|zhwikiversity: Optimize logo per commons files (T308620)]] (duration: 00m 51s)

Change 792752 merged by jenkins-bot:

[operations/mediawiki-config@master] zhwikisource: Declare commons files for logo

https://gerrit.wikimedia.org/r/792752

Mentioned in SAL (#wikimedia-operations) [2022-05-24T13:25:01Z] <taavi@deploy1002> Synchronized logos/config.yaml: Config: [[gerrit:792752|zhwikisource: Declare commons files for logo (T308620)]] (duration: 00m 53s)

Change 793127 merged by jenkins-bot:

[operations/mediawiki-config@master] zhwikisource: Optimize logo per commons files

https://gerrit.wikimedia.org/r/793127

Mentioned in SAL (#wikimedia-operations) [2022-05-24T13:25:54Z] <taavi@deploy1002> Synchronized wmf-config/logos.php: Config: [[gerrit:792752|zhwikisource: Declare commons files for logo (T308620)]] (duration: 00m 52s)

Mentioned in SAL (#wikimedia-operations) [2022-05-24T13:27:58Z] <taavi@deploy1002> Synchronized static/images/project-logos: Config: [[gerrit:793127|zhwikisource: Optimize logo per commons files (T308620)]] (duration: 00m 55s)

Change 792971 merged by jenkins-bot:

[operations/mediawiki-config@master] zhwikisource: Adjust workmark size

https://gerrit.wikimedia.org/r/792971

Mentioned in SAL (#wikimedia-operations) [2022-05-24T21:26:41Z] <cjming@deploy1002> Synchronized static/images/mobile/copyright/wikisource-wordmark-zh.svg: Config: [[gerrit:792971|zhwikisource: Adjust workmark size (T308620)]] (duration: 00m 50s)

Mentioned in SAL (#wikimedia-operations) [2022-05-24T21:27:53Z] <cjming@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:792971|zhwikisource: Adjust workmark size (T308620)]] (duration: 00m 50s)

Change 793125 merged by jenkins-bot:

[operations/mediawiki-config@master] zhwikivoyage: Generate zh-hant logo variant

https://gerrit.wikimedia.org/r/793125

Mentioned in SAL (#wikimedia-operations) [2022-05-25T20:09:58Z] <cjming@deploy1002> Synchronized static/images/project-logos: Config: [[gerrit:793125|zhwikivoyage: Generate zh-hant logo variant (T308620)]] (duration: 00m 50s)

Change 793027 merged by jenkins-bot:

[operations/mediawiki-config@master] zhwikivoyage: Declare commons files for logo and its variant

https://gerrit.wikimedia.org/r/793027

Mentioned in SAL (#wikimedia-operations) [2022-05-25T20:13:42Z] <cjming@deploy1002> Synchronized wmf-config/logos.php: Config: [[gerrit:793027|zhwikivoyage: Declare commons files for logo and its variant (T308620)]] (duration: 01m 25s)

Mentioned in SAL (#wikimedia-operations) [2022-05-25T20:14:44Z] <cjming@deploy1002> Synchronized logos/config.yaml: Config: [[gerrit:793027|zhwikivoyage: Declare commons files for logo and its variant (T308620)]] (duration: 00m 49s)

Change 799415 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] zhwiki: wmgSiteLogoVariants language fallback

https://gerrit.wikimedia.org/r/799415

Change 792973 abandoned by Stang:

[operations/mediawiki-config@master] zhwikiquote: Add logo variants

Reason:

will try w/ fallback support

https://gerrit.wikimedia.org/r/792973

Change 800793 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] Add wmgSiteLogoVariants support for Chinese Wikimedia projects

https://gerrit.wikimedia.org/r/800793

Change 802133 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] zhwiki: Use wmgSiteLogoVariants to simplify logo variant settings

https://gerrit.wikimedia.org/r/802133

Change 806944 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] Define default value for "wmgSiteLogoVariants"

https://gerrit.wikimedia.org/r/806944

Change 802133 abandoned by Stang:

[operations/mediawiki-config@master] zhwiki: Use wmgSiteLogoVariants to simplify logo variant settings

Reason:

Will be part of I1b47ab2daf10c5dc9e673ca5ebae64d98813696e

https://gerrit.wikimedia.org/r/802133

Change 806947 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] zhwikibooks: Add zh-hant variant logo

https://gerrit.wikimedia.org/r/806947

Change 806947 abandoned by Stang:

[operations/mediawiki-config@master] zhwikibooks: Add zh-hant variant logo

Reason:

Wait for a new SVG version logo 0 0

https://gerrit.wikimedia.org/r/806947

We'd better have a SVG file for the logo of zhwikibooks.

Hi @Krinkle, would you like to have a look at patch https://gerrit.wikimedia.org/r/799415 (also https://gerrit.wikimedia.org/r/806944)? I made some modification and just want to make sure if there's still anything I forgot per your previous -1 vote.

Change 822194 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] zhwiki: Use wmgSiteLogoVariantFallback to reduce duplicated code

https://gerrit.wikimedia.org/r/822194

Change 822197 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] Add wmgSiteLogoVariants support for Chinese Wikimedia projects

https://gerrit.wikimedia.org/r/822197

Change 800793 abandoned by Stang:

[operations/mediawiki-config@master] Add wmgSiteLogoVariants support for Chinese Wikimedia projects

Reason:

Replaced by I1b6808febad19a824f6ce62663306dff23a96f6d

https://gerrit.wikimedia.org/r/800793

Change 806944 merged by jenkins-bot:

[operations/mediawiki-config@master] Define default value for "wmgSiteLogoVariants"

https://gerrit.wikimedia.org/r/806944

Change 799415 merged by jenkins-bot:

[operations/mediawiki-config@master] Add language fallback support for wmgSiteLogoVariants

https://gerrit.wikimedia.org/r/799415

Mentioned in SAL (#wikimedia-operations) [2022-08-11T20:47:30Z] <thcipriani@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:806944|Define default value for "wmgSiteLogoVariants" (T305692 T308620)]] (duration: 03m 07s)

Change 822194 merged by jenkins-bot:

[operations/mediawiki-config@master] zhwiki: Use wmgSiteLogoVariantFallback to reduce duplicated code

https://gerrit.wikimedia.org/r/822194

Mentioned in SAL (#wikimedia-operations) [2022-08-11T21:04:35Z] <thcipriani@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: revert [[gerrit:806944|Define default value for "wmgSiteLogoVariants" (T305692 T308620)]] (duration: 03m 15s)

Change 826635 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] Define default value for "wmgSiteLogoVariants"

https://gerrit.wikimedia.org/r/826635

Change 826636 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] Add language fallback support for wmgSiteLogoVariants

https://gerrit.wikimedia.org/r/826636

Change 826637 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] zhwiki: Use wmgSiteLogoVariantFallback to reduce duplicated code

https://gerrit.wikimedia.org/r/826637

Change 822197 abandoned by Stang:

[operations/mediawiki-config@master] Add wmgSiteLogoVariants support for Chinese Wikimedia projects

Reason:

start with a new one

https://gerrit.wikimedia.org/r/822197

Change 826639 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] Add wmgSiteLogoVariants support for Chinese Wikimedia projects

https://gerrit.wikimedia.org/r/826639

Change 826635 merged by jenkins-bot:

[operations/mediawiki-config@master] Define default value for "wmgSiteLogoVariants"

https://gerrit.wikimedia.org/r/826635

Change 826636 merged by jenkins-bot:

[operations/mediawiki-config@master] Add language fallback support for wmgSiteLogoVariants

https://gerrit.wikimedia.org/r/826636

Change 826637 merged by jenkins-bot:

[operations/mediawiki-config@master] zhwiki: Use wmgSiteLogoVariantFallback to reduce duplicated code

https://gerrit.wikimedia.org/r/826637

Change 826611 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Revert "zhwiki: Use wmgSiteLogoVariantFallback to reduce duplicated code"

https://gerrit.wikimedia.org/r/826611

Change 826611 merged by Urbanecm:

[operations/mediawiki-config@master] Revert "zhwiki: Use wmgSiteLogoVariantFallback to reduce duplicated code"

https://gerrit.wikimedia.org/r/826611

Change 826612 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Revert "Add language fallback support for wmgSiteLogoVariants"

https://gerrit.wikimedia.org/r/826612

Change 826612 merged by Urbanecm:

[operations/mediawiki-config@master] Revert "Add language fallback support for wmgSiteLogoVariants"

https://gerrit.wikimedia.org/r/826612

Change 826613 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Revert "Define default value for "wmgSiteLogoVariants""

https://gerrit.wikimedia.org/r/826613

Change 826613 merged by Urbanecm:

[operations/mediawiki-config@master] Revert "Define default value for "wmgSiteLogoVariants""

https://gerrit.wikimedia.org/r/826613

Previous three patches get tested on mwdebug1001, and they failed to work as expected - When viewing at zhwiki under zh-cn/zh-sg/zh-my variants, site logo is still displayed in traditional Chinese (https://zh.wikipedia.org/static/images/project-logos/zhwiki.png), instead of in simplified Chinese (https://zh.wikipedia.org/static/images/project-logos/zhwiki-hans.png, also current case). I guess the problem might came from CS.php, but would like to know how to test such thing, like printing value of variable wmgSiteLogoVariants or something else.

Change 826639 abandoned by Stang:

[operations/mediawiki-config@master] Add wmgSiteLogoVariants support for Chinese Wikimedia projects

Reason:

https://gerrit.wikimedia.org/r/826639

Stang changed the task status from In Progress to Open.Sep 3 2022, 9:45 PM
Stang removed a project: Patch-For-Review.
Stang unsubscribed.

Change 847309 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] Add wmgSiteLogoVariants support to Chinese projects

https://gerrit.wikimedia.org/r/847309

Change 847309 merged by jenkins-bot:

[operations/mediawiki-config@master] Add wmgSiteLogoVariants support to Chinese projects

https://gerrit.wikimedia.org/r/847309

Mentioned in SAL (#wikimedia-operations) [2022-10-24T20:29:05Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:847309|Add wmgSiteLogoVariants support to Chinese projects (T308620)]]

Mentioned in SAL (#wikimedia-operations) [2022-10-24T20:29:25Z] <urbanecm@deploy1002> urbanecm and stang: Backport for [[gerrit:847309|Add wmgSiteLogoVariants support to Chinese projects (T308620)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-10-24T20:36:08Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:847309|Add wmgSiteLogoVariants support to Chinese projects (T308620)]] (duration: 07m 02s)

Change 848552 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] Move wmgSiteLogoVariants to logos.php

https://gerrit.wikimedia.org/r/848552

Change 848552 merged by jenkins-bot:

[operations/mediawiki-config@master] Move wmgSiteLogoVariants to logos.php

https://gerrit.wikimedia.org/r/848552

Mentioned in SAL (#wikimedia-operations) [2022-10-25T13:27:13Z] <lucaswerkmeister-wmde@deploy1002> Started scap: Backport for [[gerrit:848552|Move wmgSiteLogoVariants to logos.php (T308620 T321519)]]

Mentioned in SAL (#wikimedia-operations) [2022-10-25T13:27:36Z] <lucaswerkmeister-wmde@deploy1002> lucaswerkmeister-wmde and stang: Backport for [[gerrit:848552|Move wmgSiteLogoVariants to logos.php (T308620 T321519)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-10-25T13:33:00Z] <lucaswerkmeister-wmde@deploy1002> Finished scap: Backport for [[gerrit:848552|Move wmgSiteLogoVariants to logos.php (T308620 T321519)]] (duration: 05m 47s)

Stang removed a project: Patch-For-Review.
Stang updated the task description. (Show Details)