Page MenuHomePhabricator
Create Task
Maniphest T305692

Support language fallback for logo variants
Closed, DeclinedPublic
Actions

Description

There are at least 5 Chinese wikis that still have logo variant overrides in site css (T273578), the current approach available in the config is to copy and paste the same logo definition 4 times.
They don't have a wordmark or tagline now, but they may have in the future, which will be a big duplication in the config.

As a part of the user interface, it should be able to follow the fallback chain defined as language properties, like the fallback for interface messages.
We also want to limit the fallback depth, since the fallback chain is not limited to the same group of variants, so I'd like to introduce a new key fallback.

Expected config:

'wmgSiteLogoVariants' => [
	'zhwiki' => [
		'zh-hans' => [
			'fallback' => [ 'zh-cn', 'zh-my', 'zh-sg' ],
			'1x' => '/static/images/project-logos/zhwiki-hans.png',
			'1.5x' => '/static/images/project-logos/zhwiki-hans-1.5x.png',
			'2x' => '/static/images/project-logos/zhwiki-hans-2x.png',
			'wordmark' => [
				'src' => '/static/images/mobile/copyright/wikipedia-wordmark-zh-hans.svg',
				'width' => 105,
				'height' => 23,
			],
			'tagline' => [
				'src' => '/static/images/mobile/copyright/wikipedia-tagline-zh-hans.svg',
				'width' => 103,
				'height' => 15,
			],
		],
	],
],

Inspired by the old description of T273578 by @Legoktm

Details

SubjectRepoBranchLines +/-
Add language fallback support for wmgSiteLogoVariantsoperations/mediawiki-configmaster+13 -0
Define default value for "wmgSiteLogoVariants"operations/mediawiki-configmaster+5 -0
Support language fallback for logo variantsmediawiki/coremaster+25 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Func created this task.Apr 8 2022, 1:12 PM
Restricted Application added subscribers: Stang, Aklapper. · View Herald TranscriptApr 8 2022, 1:12 PM
gerritbot added a comment.Apr 8 2022, 1:19 PM

Change 775422 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] Support language fallback for logo variants

https://gerrit.wikimedia.org/r/775422

gerritbot added a project: Patch-For-Review.Apr 8 2022, 1:19 PM
Jdlrobson added a comment.Apr 8 2022, 3:04 PM

The suggested solution adds complexity to some already complicated code. If the problem trying to be solved is to avoid copy and pasting, I am wondering if you have considered a refactor of the configuration code itself?

the current approach available in the config is to copy and paste the same logo definition 4 times.

The current configuration (wmf-config/CommonSettings.php) looks like this:

if ( isset( $wmgSiteLogo1x ) ) {
	$wgLogos = [
		'1x' => $wmgSiteLogo1x ?? null,
		'1.5x' => $wmgSiteLogo1_5x ?? null,
		'2x' => $wmgSiteLogo2x ?? null,
		'icon' => $wmgSiteLogoIcon ?? null,
		'wordmark' => $wmgSiteLogoWordmark ?? null,
		'tagline' => $wmgSiteLogoTagline ?? null,
		'variants' => $wmgSiteLogoVariants ?? null,
	];
}

Couldn't you do something like this:

if  ( in_array(   $wgLanguageCode, [ 'zh-cn', 'zh-my', 'zh-sg' ] ) ) {
  $wgLogos['variants'] = $wmgSiteLogoChineseVariants;
}

with wmf-config/InitialiseSettings.php:

`
'wmgSiteLogoChineseVariants' => [
			'1x' => '/static/images/project-logos/zhwiki-hans.png',
			'1.5x' => '/static/images/project-logos/zhwiki-hans-1.5x.png',
			'2x' => '/static/images/project-logos/zhwiki-hans-2x.png',
			'wordmark' => [
				'src' => '/static/images/mobile/copyright/wikipedia-wordmark-zh-hans.svg',
				'width' => 105,
				'height' => 23,
			],
			'tagline' => [
				'src' => '/static/images/mobile/copyright/wikipedia-tagline-zh-hans.svg',
				'width' => 103,
				'height' => 15,
			],
Winston_Sung moved this task from Backlog to MediaWiki core on the Chinese-Sites board.Apr 26 2022, 3:20 PM
gerritbot added a comment.May 10 2022, 12:34 PM

Change 775422 abandoned by Func:

[mediawiki/core@master] Support language fallback for logo variants

Reason:

https://gerrit.wikimedia.org/r/775422

Restricted Application added a subscriber: Ericliu1912. · View Herald TranscriptMay 10 2022, 12:34 PM
Func closed this task as Declined.May 10 2022, 12:38 PM
Maintenance_bot removed a project: Patch-For-Review.May 10 2022, 1:31 PM
Stang moved this task from MediaWiki core to Closed on the Chinese-Sites board.May 10 2022, 5:05 PM
Stang unsubscribed.May 12 2022, 10:21 PM
Winston_Sung added a parent task: T273578: Wikis with language variants must override logo in Common.css.May 22 2022, 2:51 PM
Winston_Sung subscribed.
Winston_Sung added a comment.May 22 2022, 2:53 PM

I think we should use the language fallback chain instead of defining every language variant.

Winston_Sung mentioned this in T303437: [Epic] Multivariant and multilingual wiki fixes and improvements.May 22 2022, 3:01 PM
gerritbot added a comment.May 25 2022, 9:32 PM

Change 799415 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] Add language fallback support for wmgSiteLogoVariants

https://gerrit.wikimedia.org/r/799415

gerritbot added a project: Patch-For-Review.May 25 2022, 9:32 PM
gerritbot added a comment.Jun 20 2022, 9:16 PM

Change 806944 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] Define default value for "wmgSiteLogoVariants"

https://gerrit.wikimedia.org/r/806944

gerritbot added a comment.Aug 11 2022, 8:39 PM

Change 806944 merged by jenkins-bot:

[operations/mediawiki-config@master] Define default value for "wmgSiteLogoVariants"

https://gerrit.wikimedia.org/r/806944

gerritbot added a comment.Aug 11 2022, 8:45 PM

Change 799415 merged by jenkins-bot:

[operations/mediawiki-config@master] Add language fallback support for wmgSiteLogoVariants

https://gerrit.wikimedia.org/r/799415

Stashbot mentioned this in T308620: HIDPI support for logos among Chinese projects.Aug 11 2022, 8:47 PM

Mentioned in SAL (#wikimedia-operations) [2022-08-11T20:47:30Z] <thcipriani@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:806944|Define default value for "wmgSiteLogoVariants" (T305692 T308620)]] (duration: 03m 07s)

Stashbot added a comment.Aug 11 2022, 9:04 PM

Mentioned in SAL (#wikimedia-operations) [2022-08-11T21:04:35Z] <thcipriani@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: revert [[gerrit:806944|Define default value for "wmgSiteLogoVariants" (T305692 T308620)]] (duration: 03m 15s)

Maintenance_bot removed a project: Patch-For-Review.Aug 11 2022, 9:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits