Follows-up https://gerrit.wikimedia.org/r/c/mediawiki/core/+/769740, \cc @Jdlrobson @Jdforrester-WMF
| Before | After |
|---|---|
I believe this is not the intended design and not expected as end-result.
It is (implicitly) rendered at 160x160px instead of in the standard x135px box that MediaWiki expects for logos, due to having no width of its own, and having no CSS background-size rule.
Square logos are rendered at 135x135px, with additional reserved space in the skin layout for taller logos like Commons, or wider logos like Wikidata. This information must come from the image file or the CSS, not the skin.
I believe this is a side-effect of an SVG incorrectly being placed inside the wgLogos[1x] configuration, which currently only supports a raster file that provides its own fixed width and height information.
Our CSS only sets background-size for higher DPI and SVG keys, which means as-written SVGs are only suitable for svg key, not for 1x (which requires a raster file). That's what the svg key exists for after all, and these would always be set in addition to a 1x raster file.
This could alternatively also repaired in other ways, e.g. by implementing support for SVG under 1x in the SkinModule, and adjusting the generated CSS accordingly to include a size declaration, or by providing a PNG at 1x and setting the SVG as the value for svg.
