Page MenuHomePhabricator

Keyboard shortcuts dialog in the editor doesn't work in DiscussionTools
Closed, ResolvedPublic

Description

Keyboard shortcuts dialog in the editor doesn't work in DiscussionTools.

Steps to reproduce:

  1. Open the reply tool or new topic tool on any page (e.g. https://en.wikipedia.org/wiki/Talk:The_Fighting_Temeraire)
  2. Press Ctrl+?

The dialog doesn't open and an exception is thrown: TypeError: ve.init.target.getSaveButtonLabel is not a function. When pressing it again, the dialog opens but it is empty.

image.png (2×3 px, 312 KB)

Related Objects

Event Timeline

Change 793132 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] CommentTargetWidget: Exclude save commands

https://gerrit.wikimedia.org/r/793132

Change 793132 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] CommentTargetWidget: Exclude save commands

https://gerrit.wikimedia.org/r/793132

matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.

Before fix:

Screenshot 2022-05-23 at 13.10.33.png (1×3 px, 400 KB)

Dialog is displayed as expected:

Screenshot 2022-05-23 at 20.17.00.png (846×380 px, 58 KB)