Page MenuHomePhabricator

GlobalRename not renaming some accounts
Closed, ResolvedPublicBUG REPORT

Description

See rename logs, here some usernames have started showing wiki suffix (@enwiki,@metawik...), only these ones have problems.

For example see this one, it's the first rename with the problem, here the account got renamed to "Саша Попов Александр Алексеевич" but CA shows it doesn't exist, but GRP shows the rename is successfully done.

Same thing with other renames where the rename log is showing wiki suffix for previous username. It says the rename's done but neither user gets renamed nor page moves happen.

First I thought it to be my browser's cache problem but it's same with other browsers. Also checked with alternative account.

Event Timeline

Reported here (SRUC), as request is "approved" but nothing happened. (FYI @Superpes15).

I noticed also that a "failed" old rename appear again on Special:GlobalRenameProgress:
Dzoo → DZoo since 8 November 2021.
Related to T219279

This is weird! It seems that the problem is only for the renaming performed via queue.
But I also noticed (maybe?) another strange thing: several users are making multiple requests within a few minutes, if I'm not mistaken they should receive a message that warns them that there is already a request in the queue and they cannot make another one until the first has been processed, but maybe I’m wrong.

But I also noticed (maybe?) another strange thing: several users are making multiple requests within a few minutes, if I'm not mistaken they should receive a message that warns them that there is already a request in the queue and they cannot make another one until the first has been processed, but maybe I’m wrong.

I don't think there's connection: T172604: Prevent users to submit multiple rename requests if there are pending requests and https://lists.wikimedia.org/hyperkitty/list/global-renamers@lists.wikimedia.org/thread/U7CGFESFKJHWI7KUOGVJZ6BGUGS7KDFA

Hopefully they can still use their account with old name before this is fixed.

Edit: I just see the link on Alaa's comment so I think they can still use their account.

@Zabe I wonder if this can be caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/774972? That could explain the Username@somewiki suffix that we're seeing in the rename logs.

Change 793797 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CentralAuth@master] Revert "Populate rq_wiki with the wiki where the rename was requested"

https://gerrit.wikimedia.org/r/793797

Change 793798 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CentralAuth@wmf/1.39.0-wmf.12] Revert "Populate rq_wiki with the wiki where the rename was requested"

https://gerrit.wikimedia.org/r/793798

Change 793797 merged by Samtar:

[mediawiki/extensions/CentralAuth@master] Revert "Populate rq_wiki with the wiki where the rename was requested"

https://gerrit.wikimedia.org/r/793797

In T308895#7946510, @Majavah wrote:

@Zabe I wonder if this can be caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/774972? That could explain the Username@somewiki suffix that we're seeing in the rename logs.

Yes. Btw I am not sure how many requests there are with the rq_wiki value populated. But we probably need to change them back to NULL by hand in order to prevent this from happening for those requests as well.

Suprisingly this doesn't seem to have caused any unattached local accounts, since the renameuser_status protections in LocalRenameJob prevented the actual renames from happening on the wiki where the rename was requested from.

In T308895#7946510, @Majavah wrote:

@Zabe I wonder if this can be caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/774972? That could explain the Username@somewiki suffix that we're seeing in the rename logs.

Yes. Btw I am not sure how many requests there are with the rq_wiki value populated. But we probably need to change them back to NULL by hand in order to prevent this from happening for those requests as well.

Looks like we had ~50 approved renames that we'll need to manually repeat (I can write a script for that) and a further 20 requests in the queue that we can fix by updating rq_wiki to null.

wikiadmin@10.192.16.104(centralauth)> select rq_status, count(*) from renameuser_queue where /* recent requests only */ rq_id > 90000 and rq_wiki is not null and rq_status != 'rejected' group by rq_status;
+-----------+----------+
| rq_status | count(*) |
+-----------+----------+
| pending   |       21 |
| approved  |       48 |
+-----------+----------+
2 rows in set (0.004 sec)

Change 793798 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.39.0-wmf.12] Revert "Populate rq_wiki with the wiki where the rename was requested"

https://gerrit.wikimedia.org/r/793798

Mentioned in SAL (#wikimedia-operations) [2022-05-21T17:58:50Z] <taavi@deploy1002> Synchronized php-1.39.0-wmf.12/extensions/CentralAuth: Backport: [[gerrit:793798|Revert "Populate rq_wiki with the wiki where the rename was requested" (T308895)]] (duration: 00m 51s)

Mentioned in SAL (#wikimedia-operations) [2022-05-21T18:06:06Z] <taavi> set rq_wiki = null for 26 rows in centralauth.renameuser_queue status table T308895

Change 794675 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/WikimediaMaintenance@master] Add a script to fix T308895 renames

https://gerrit.wikimedia.org/r/794675

Change 794675 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@master] Add a script to fix T308895 renames

https://gerrit.wikimedia.org/r/794675

Change 793800 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/WikimediaMaintenance@wmf/1.39.0-wmf.12] Add a script to fix T308895 renames

https://gerrit.wikimedia.org/r/793800

Change 793800 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@wmf/1.39.0-wmf.12] Add a script to fix T308895 renames

https://gerrit.wikimedia.org/r/793800

Mentioned in SAL (#wikimedia-operations) [2022-05-23T05:25:38Z] <taavi@deploy1002> Synchronized php-1.39.0-wmf.12/extensions/WikimediaMaintenance/fixT308895BrokenRenames.php: Backport: [[gerrit:793800|Add a script to fix T308895 renames (T308895)]] (duration: 00m 51s)

Mentioned in SAL (#wikimedia-operations) [2022-05-23T08:12:03Z] <taavi> fixing renames of 44 accounts T308895

taavi claimed this task.