Page MenuHomePhabricator
Create Task
Maniphest T309386

ZObject creation with invalid Z11K1 goes through when it should not
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  • In ApiSandbox, go to the wikilambda_edit API and load the creation example
  • (in beta cluster)
  • See that the value of Z11K1 is a language code and not a language Zid

Observed behavior:

  • The ZObject can be successfully created

Expected behavior:

  • The ZObject creation should fail

Completion checklist:

  • Functionality
    • The issue has been resolved
    • The issue has been peer reviewed
    • The issue has been merged
  • Engineering
    • There are existing and passing unit/integration tests effectively testing its success and its failure
    • Explicit regression test mentioning the bug

Details

SubjectRepoBranchLines +/-
CanonicalZObjectTest: Disable tests that disagree between Opis and Ajvmediawiki/extensions/WikiLambdamaster+28 -10
Add tests that fail with typed lists in PHPmediawiki/extensions/WikiLambdamaster+31 -1
Update function-schemata sub-module to HEAD (5c8c897)mediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (5c8c897)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (5c8c897)mediawiki/extensions/WikiLambdamaster+1 -1
Add test data for monolingual strings with old language code formatmediawiki/services/function-schematamaster+40 -0
Customize query in gerrit

Related Objects

Event Timeline

gengh created this task.May 27 2022, 10:09 AM
gengh claimed this task.May 31 2022, 10:34 AM
gengh added a comment.May 31 2022, 3:16 PM

Some exploration into this bug threw light into something that doesn't seem to be trivial. The test data available in function-schemata for the objects: Z2, Z4, Z8, Z12, Z32 and Z60, particularly those tests that focus on benjamin arrays, it passes successfully when the tests are run in function-schemata (with Ajv), but they fail when running in Wikilambda (Opis).

gerritbot added a comment.May 31 2022, 3:19 PM

Change 801735 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Add tests that fail with typed lists in PHP

https://gerrit.wikimedia.org/r/801735

gerritbot added a project: Patch-For-Review.May 31 2022, 3:19 PM
gerritbot added a comment.May 31 2022, 3:21 PM

Change 801736 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/services/function-schemata@master] Add test data for monolingual strings with old language code format

https://gerrit.wikimedia.org/r/801736

gerritbot added a comment.May 31 2022, 6:39 PM

Change 801736 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Add test data for monolingual strings with old language code format

https://gerrit.wikimedia.org/r/801736

gengh mentioned this in rMSFSd1e281819fff: Add test data for monolingual strings with old language code format.May 31 2022, 6:39 PM
gengh removed a project: Abstract Wikipedia Fix-It tasks.Jun 1 2022, 11:09 AM
gerritbot added a comment.Jun 3 2022, 5:00 PM

Change 802801 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (31f931f)

https://gerrit.wikimedia.org/r/802801

gerritbot added a comment.Jun 3 2022, 5:00 PM

Change 802800 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (31f931f)

https://gerrit.wikimedia.org/r/802800

gerritbot added a comment.Jun 3 2022, 5:00 PM

Change 802802 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (31f931f)

https://gerrit.wikimedia.org/r/802802

gerritbot added a comment.Jun 3 2022, 6:11 PM

Change 802800 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5c8c897)

https://gerrit.wikimedia.org/r/802800

gerritbot added a comment.Jun 3 2022, 6:12 PM

Change 802801 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (5c8c897)

https://gerrit.wikimedia.org/r/802801

Jdforrester-WMF mentioned this in rMSFO5d32b2ce3638: Update function-schemata sub-module to HEAD (5c8c897).Jun 3 2022, 6:12 PM
gerritbot added a comment.Jun 3 2022, 6:17 PM

Change 802802 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (5c8c897)

https://gerrit.wikimedia.org/r/802802

Jdforrester-WMF mentioned this in rMSFE63f288e05d00: Update function-schemata sub-module to HEAD (5c8c897).Jun 3 2022, 6:18 PM
gerritbot added a comment.Jun 3 2022, 6:33 PM

Change 802818 had a related patch set uploaded (by Jforrester; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] CanonicalZObjectTest: Disable tests that disagree between Opis and Ajv

https://gerrit.wikimedia.org/r/802818

gerritbot added a comment.Jun 3 2022, 6:40 PM

Change 801735 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add tests that fail with typed lists in PHP

https://gerrit.wikimedia.org/r/801735

gerritbot added a comment.Jun 3 2022, 6:40 PM

Change 802818 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] CanonicalZObjectTest: Disable tests that disagree between Opis and Ajv

https://gerrit.wikimedia.org/r/802818

Jdforrester-WMF subscribed.Jun 3 2022, 6:57 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 3 2022, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 3 2022, 7:29 PM
DVrandecic moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Jun 7 2022, 6:42 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
gengh moved this task from Incoming to Ready: G6. Stable & secure on the Abstract Wikipedia team (Phase θ – Throttling) board.Aug 2 2022, 12:45 PM
gengh removed gengh as the assignee of this task.Aug 22 2022, 1:29 PM
Jdforrester-WMF updated the task description. (Show Details)Jun 8 2023, 8:42 PM
Jdforrester-WMF moved this task from Phase θ – Throttling to To triage: Nice-to-haves on the Abstract Wikipedia team board.Jun 16 2023, 8:49 AM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase θ – Throttling).
gengh changed the task status from Open to In Progress.Aug 14 2023, 3:41 PM
gengh claimed this task.
gengh triaged this task as High priority.
gengh moved this task from To triage: Nice-to-haves to In Progress on the Abstract Wikipedia team board.
gengh updated the task description. (Show Details)Aug 30 2023, 7:42 AM

Added front-end mechanisms to clear invalid monolingual string before submission. Issue and tests solved with this patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/949538

gengh moved this task from In Progress to Verify in production on the Abstract Wikipedia team board.Aug 30 2023, 7:43 AM
Etonkovidova closed this task as Resolved.Sep 27 2023, 8:01 PM
Etonkovidova subscribed.

Checked on wikifunctions wmf.28, Zobject creation fails with "message": "Not wellformed"

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL