Page MenuHomePhabricator

Create mathlatexml table?
Closed, ResolvedPublic

Description

T307896 updates the database script and creates the table mathlatexml regardless of the configuration. In production, the new table should never be used (because the respective configuration is not switched on). However, to be consistent with what update.php would do, the table should probably be created. If not, the job is done and the task can be closed.

Otherwise:

Event Timeline

Marostegui subscribed.

@Physikerwelt I am not sure what this ticket is about, but DBAs do not handle table creation. That is handled during the release process. Unless this is for a misc cluster.
I am adding the releng team here to see if they can help.

https://wikitech.wikimedia.org/wiki/Creating_new_tables has more info. If you want it to be in mw in production. We need some info (as outlined in the wiki page) but once we sign it off, you need someone from deployers to do it for you.

Physikerwelt renamed this task from Review schema changes for T307896 to Create mathlatexml table?.Jun 1 2022, 9:15 AM
Physikerwelt updated the task description. (Show Details)

@Ladsgroup thank you. Sorry I missed the first point in https://wikitech.wikimedia.org/wiki/Schema_changes#What_is_not_a_schema_change I honestly don't know if it should be in production or not. However, I think it is good to discuss if it should be in production or not.

Thanks! Does this mean this table will be always empty? We need these numbers to plan the growth.

Yes. I wanted to express that with the zeros in the ticket description.

I think it won't be issue but to double check. It will stay as an empty even when we switch to php 8 in production?

If it's not being read or written in production, you can simply avoid creating it, for example bot_passwords table does not exist in production databases.

Yeah, if we don't really need it - I would rather not get it created. For example in s3 that means around 1800 new files (900 wikis) on the hosts themselves.

I think it won't be issue but to double check. It will stay as an empty even when we switch to php 8 in production?

yes. it does not depend on the PHP version but on the setting $wgMathValidModes

However, this comment
https://github.com/wikimedia/operations-mediawiki-config/blob/c47cd56b0312ca269280f2a433c0eda11cca8b05/wmf-config/CommonSettings.php#L2947
suggest that there is a chance that this setting could be enabled by chance. This could happen if the default in the math extension was changed. One option to prevent this is to overwrite $wgMathValidModes explicitly and link to this discussion in the comments.

Do you think this would be required?

If it's not being read or written in production, you can simply avoid creating it, for example bot_passwords table does not exist in production databases.

All right, as long as it is consistent with other extensions. I don't see a problem. I just want to avoid that the Math extension behaves differently compared to other extensions.

We can override it in production to make sure it never gets turned on by mistake. That's much easier than maintaining 1000 tables in production :P

Change 802443 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[operations/mediawiki-config@master] Explicitly set math rendering modes

https://gerrit.wikimedia.org/r/802443

Change 802443 merged by jenkins-bot:

[operations/mediawiki-config@master] Explicitly set math rendering modes

https://gerrit.wikimedia.org/r/802443

Mentioned in SAL (#wikimedia-operations) [2022-07-25T07:37:37Z] <kartik@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:802443|Explicitly set math rendering modes (T309686)]] (duration: 03m 11s)