Error when installing Math extension with MediaWiki on PHP 8
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Bluehill395
	May 9 2022, 9:16 AM

Description

List of steps to reproduce (step by step, including full links if applicable):

When installing MediaWiki on PHP 8, choose to install the Math extension. (regardless of web installer or CLI)

What happens?: The following error occurs:

[96336f8be79bfcf875dcef7b] [no req]   TypeError: array_map(): Argument #2 ($array) must be of type array, null given
Backtrace:
from C:\inetpub\wwwroot\w\extensions\Math\src\Hooks.php(48)
#0 C:\inetpub\wwwroot\w\extensions\Math\src\Hooks.php(48): array_map()
#1 C:\inetpub\wwwroot\w\includes\HookContainer\HookContainer.php(338): MediaWiki\Extension\Math\Hooks::onLoadExtensionSchemaUpdates()
#2 C:\inetpub\wwwroot\w\includes\HookContainer\HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook()
#3 C:\inetpub\wwwroot\w\includes\HookContainer\HookRunner.php(2333): MediaWiki\HookContainer\HookContainer->run()
#4 C:\inetpub\wwwroot\w\includes\installer\DatabaseUpdater.php(142): MediaWiki\HookContainer\HookRunner->onLoadExtensionSchemaUpdates()
#5 C:\inetpub\wwwroot\w\includes\installer\DatabaseUpdater.php(500): DatabaseUpdater->loadExtensionSchemaUpdates()
#6 C:\inetpub\wwwroot\w\includes\installer\DatabaseInstaller.php(349): DatabaseUpdater->doUpdates()
#7 C:\inetpub\wwwroot\w\includes\installer\Installer.php(1680): DatabaseInstaller->createExtensionTables()
#8 C:\inetpub\wwwroot\w\includes\installer\CliInstaller.php(211): Installer->performInstallation()
#9 C:\inetpub\wwwroot\w\maintenance\install.php(144): CliInstaller->execute()
#10 C:\inetpub\wwwroot\w\maintenance\doMaintenance.php(114): CommandLineInstaller->execute()
#11 C:\inetpub\wwwroot\w\maintenance\install.php(205): require_once(string)
#12 {main}

What should have happened instead?: It must be installed normally without errors.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.: MediaWiki 1.38.0-rc.0, Windows Server vNext (Build 25110), IIS, MariaDB 10.6.7 and PHP 8.1.5.

Details

	Subject	Repo	Branch	Lines +/-
	Set up mathoid and mathlatexml regardless of configuration	mediawiki/extensions/Math	REL1_38	+21 -36
	Set up mathoid and mathlatexml regardless of configuration	mediawiki/extensions/Math	master	+21 -36

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	Physikerwelt	T307896 Error when installing Math extension with MediaWiki on PHP 8
		Resolved		Physikerwelt	T309686 Create mathlatexml table?

Event Timeline

Bluehill395 created this task.May 9 2022, 9:16 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 9 2022, 9:16 AM

Bluehill395 renamed this task from When installing MediaWiki on Windows, selecting the Math extension throws an error. to Error when installing Math extension with MediaWiki on Windows.May 9 2022, 9:27 AM

Can you share your localsettings?

The localsettings were not created because it was an error during mediawiki installation. (not database updates)

So this is a fresh installation and you downloaded the release version. I will try to reproduce it will take a few days until I come to it...

Physikerwelt moved this task from Next-up to Doing on the Math board.May 13 2022, 2:18 PM

Unfortunately, I can not reproduce the problem. For me, it works well on Windows. Could you provide step-by-step instructions on how you configure your environment? The MediaWiki help page is unfortunately not very helpful if one wants to install MW on Windows.

I have set up IIS, PHP, MariaDB following the instructions outlined here. (The title is Server "2016", but it worked fine on newer Windows as well.) Also, I downloaded the zip from here and didn't use git. Just in case, I will try Git's REL1_38 branch.

I downloaded using Git, but the same thing happened.

Can you install without MathExtension being enabled and enable Math in a subsequent step?

Yes, can enable it later.

Ok. In the meantime I was able to reproduce the error, thank you for the download link.

I found out that there is a problem not only with Windows but also with Ubuntu, and I looked into it and found out that there is a problem when using PHP 8. I tried PHP 7.4, but there is no problem.

Bluehill395 updated the task description. (Show Details)Jun 1 2022, 2:07 AM

This might be related to T88946 with a possible solution pointed out in https://phabricator.wikimedia.org/T186785#3956673

I don't know how to fix this. It uses globals ($wgMathValidModes;) to get the math modes that are null if the web updater is used. One can not avoid globals via MediaWiki\MediaWikiServices::getInstance()->getMainConfig() as the hook runs before services are initialized. At least that is how I interpret the comment

		// This hook runs before services are initialized, so we cannot
		// use MathConfig service directly.

On the contrary, looking at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+blame/master/includes/installer/DatabaseUpdater.php it seems that the config should be accessible.

What one could do is a workaround like if is_null($wgMathValidModes) create tables for all possible modes, or just create all tables regardless of the rendering modes. Would that be acceptable?

Aklapper added a project: PHP 8.0 support.Jun 1 2022, 6:27 AM

A possible suggestion is to just remove the $wgMathValidModes global from the onLoadExtensionSchemaUpdates hook handler and always create the two database tables mathlatexml and mathoid. Yea, they might go unused. But that shouldn't be a problem.

What if somebody decides to enable one of the two modes latexml or mathml on a wiki that was originally set up with these modes disabled? As of now you would run into unexpected exceptions that can only be resolved by running update.php again to create the missing database table(s). That's unexpected, in my opinion. The current behavior is not consistent anyway because there is no code (as far as I can see) that deletes a table when I disable one of these modes. So why bother partly "optimizing" the first update.php run like this?

@thiemowmde thank you. Exactly. I will change this.

Physikerwelt added a project: Schema-change.Jun 1 2022, 8:35 AM

Change 802056 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Set up mathoid and mathlatexml regardless of configuration

https://gerrit.wikimedia.org/r/802056

gerritbot added a project: Patch-For-Review.Jun 1 2022, 8:39 AM

Physikerwelt added a subtask: T309686: Create mathlatexml table?.Jun 1 2022, 8:46 AM

Physikerwelt mentioned this in T309686: Create mathlatexml table?.Jun 1 2022, 9:15 AM

Change 802056 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Set up mathoid and mathlatexml regardless of configuration

https://gerrit.wikimedia.org/r/802056

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 1 2022, 11:00 AM

Physikerwelt moved this task from Ready to implement to Doing on the Math board.Jun 1 2022, 11:19 AM

@Bluehill395 with the latest master the error should no longer appear. Are you able to test with the latest master, or do you need this change to be backported to the 1_38 release?

Change 802108 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@REL1_38] Set up mathoid and mathlatexml regardless of configuration

https://gerrit.wikimedia.org/r/802108

I guess given that 1_38 is the first release (T232948) with Math bundled it makes perfect sense to backport the change to the 1_38 release branch.

Change 802108 merged by jenkins-bot:

[mediawiki/extensions/Math@REL1_38] Set up mathoid and mathlatexml regardless of configuration

https://gerrit.wikimedia.org/r/802108

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2022, 12:30 PM

@thiemowmde Thank you again for helping us.

Physikerwelt edited projects, added MW-1.38-release; removed User-Physikerwelt.Jun 1 2022, 12:33 PM

Works on master branch and PHP 8.1.6.

Physikerwelt closed subtask T309686: Create mathlatexml table? as Resolved.Jul 25 2022, 7:55 AM

Error when installing Math extension with MediaWiki on PHP 8Closed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Error when installing Math extension with MediaWiki on PHP 8
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Related Objects
Search...