Page MenuHomePhabricator

Bundle Math extension with MediaWiki
Open, MediumPublic

Description

Extension Math does not have any additional dependencies, but php-curl. We might want to consider adding it to the default bundle.

  • Passed security review or already Wikimedia deployed
  • Voting CI structure tests
  • Runs MediaWiki-CodeSniffer
  • Runs phan
  • Runs seccheck
  • Supports MySQL, SQLite, and Postgres (if there are schema changes)
  • GPL v2 or later compatible license
  • Extension's default configuration provides optimal experience
  • Tested with web installer
  • Resolve dependency upon php-curl, if necessary

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2019, 1:14 PM
Physikerwelt renamed this task from Add extension math to the default modules in REL 1.34 to Add extension math to the default extensions in REL 1.34.Sep 15 2019, 1:14 PM
BPirkle added a subscriber: BPirkle.EditedSep 17 2019, 2:42 PM

Also consider T137926 (Support running MediaWiki without 'curl' PHP extension)

CCicalese_WMF renamed this task from Add extension math to the default extensions in REL 1.34 to Bundle Math extension with MediaWiki.Sep 17 2019, 5:24 PM
CCicalese_WMF removed a project: Release.
CCicalese_WMF updated the task description. (Show Details)

Is there a direct dependency of Math upon php-curl, or is it an indirect dependency through MultiHttpClient? If the latter, perhaps T202352 could eliminate that dependency. Since I do not believe there is a way in the web installer to prevent enabling Math if php-curl is not present, this may be a blocker for bundling this extension at this point.

CCicalese_WMF edited projects, added MW-1.35-release; removed MW-1.34-release.

I'm bumping this to 1.35 for now until the php-curl dependency is clarified. If this can be resolved in time for the 1.34 release, we can bump it back.

Is there a direct dependency of Math upon php-curl, or is it an indirect dependency through MultiHttpClient? If the latter, perhaps T202352 could eliminate that dependency.

It comes with MultiHttpClient.

https://github.com/wikimedia/mediawiki-extensions-Math/blob/54d1b77401a250d24a6923193c5c73459a10c2c2/src/MathRestbaseInterface.php#L170

Since I do not believe there is a way in the web installer to prevent enabling Math if php-curl is not present, this may be a blocker for bundling this extension at this point.

Yes, one either needs the MultiHttpClient or to install nodejs, and mathoid and do configuration, which is some effort. See
https://github.com/physikerwelt/mediawiki-docker/commit/b2f700ecb2f6fb9753c50e21ca70981ff3eff457#diff-3254677a7917c6c01f55212f86c57fbfR94-R99

Physikerwelt updated the task description. (Show Details)Sep 17 2019, 6:51 PM

Extension's default configuration provides optimal experience

Not sure what this means, but there is nothing one can do to improve the default configuration unless one has special needs.

I guess the strict definition of optimal as the minimum of a well-defined loss function, is not meant here.

Krinkle moved this task from Blocker to Bundling on the MW-1.35-release board.Oct 11 2019, 10:44 PM
Legoktm moved this task from Blocker to Bundling on the MW-1.36-release board.Jul 15 2020, 4:30 AM