SkinMinervaReplaceNotificationsBadge (phase 2)
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 1 2022, 11:51 PM

Description

T301263 removed the SkinMinervaReplaceNotificationsBadge from production

When T301263 is QAed, resolved and running in production, it will be safe to remove the usage of the SkinMinervaReplaceNotificationsBadge hook inside Echo.

The code for T301263 is currently scheduled to be in production everywhere from Thursday 9th.

Acceptance criteria

There should be no results on https://codesearch.wmcloud.org/search/?q=SkinMinervaReplaceNotificationsBadge&i=nope&files=&excludeFiles=&repos=
Echo should work as expected in the mobile view.

Details

	Subject	Repo	Branch	Lines +/-
	Drop SkinMinervaReplaceNotificationsBadge hook	mediawiki/extensions/Echo	master	+1 -68

Customize query in gerrit

Related Objects

Mentioned In: T301263: Remove the SkinMinervaReplaceNotificationsBadge hook
Mentioned Here: T301263: Remove the SkinMinervaReplaceNotificationsBadge hook

Event Timeline

Jdlrobson created this task.Jun 1 2022, 11:51 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJun 1 2022, 11:51 PM

Jdlrobson mentioned this in T301263: Remove the SkinMinervaReplaceNotificationsBadge hook.Jun 1 2022, 11:58 PM

Change 761004 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Echo@master] Drop SkinMinervaReplaceNotificationsBadge hook

https://gerrit.wikimedia.org/r/761004

gerritbot added a project: Patch-For-Review.Jun 1 2022, 11:59 PM

kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jun 2 2022, 8:30 AM

kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 761004 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Drop SkinMinervaReplaceNotificationsBadge hook

https://gerrit.wikimedia.org/r/761004

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 22 2022, 4:00 PM

Jdlrobson moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 22 2022, 4:11 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 22 2022, 4:30 PM

Etonkovidova updated the task description. (Show Details)Jul 19 2022, 10:26 PM

Checked the UI on testwiki wmf.21 (and checked Test group: echo for wmf.19) - all look as expected.

SkinMinervaReplaceNotificationsBadge (phase 2)Closed, ResolvedPublicBUG REPORTActions