The SkinMinervaReplaceNotificationsBadge hook should no longer be needed with the changes to the core skin architecture to recognize notifications.
TODO
- Update Echo to work without the SkinMinervaReplaceNotificationsBadge hook
- Make Minerva use core notifications data
QA
- Confirm there are no UI regressions in the Echo group on pixel.wmcloud.org/ and that all the scenario screenshots show evidence of a logged in user (these scenarios should never show screenshots for anonymous users)
- Exploratory testing: Please login on mobile and explore the Echo notification feature, recording any behaviour or change in visual design that looks unexpected.
Sign off steps
Next step will be: T309748
QA Results - Beta
AC | Status | Details |
---|---|---|
1 | ✅ | T301263#7981819 |
2 | ✅ | T301263#7981819 |
QA Results - Prod
AC | Status | Details |
---|---|---|
1 | ✅ | T301263#8010501 |
2 | ✅ | T301263#8010501 |