Page MenuHomePhabricator
Create Task
Maniphest T309984

Special:QuitMentorship reassigns another mentor's mentee
Closed, ResolvedPublicBUG REPORT
Actions

Description

https://ko.wikipedia.org/wiki/%ED%8A%B9%EC%88%98:%EA%B8%B0%EB%A1%9D?type=growthexperiments&user=&page=&wpdate=&tagfilter=&subtype=setmentor&uselang=en

A mentor recently retired from mentorship. They followed the instructions on the Special:MentorDashboard to reassign mentees through Special:QuitMentorship. However, as you can see from the above log, Special:QuitMentorship reassigns not only the mentee of the retired mentor, but also the mentees of other mentors. (Not all mentees appear to be affected)

Details

SubjectRepoBranchLines +/-
Add QuitMentorshipIntegrationTestmediawiki/extensions/GrowthExperimentsmaster+73 -0
QuitMentorship: Only process primary mentorsmediawiki/extensions/GrowthExperimentsmaster+4 -2
Customize query in gerrit

Related Objects

Event Timeline

Bluehill395 created this task.Jun 6 2022, 2:29 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 6 2022, 2:29 PM
Restricted Application added subscribers: revi, Aklapper. · View Herald Transcript
Bluehill395 added a comment.Jun 6 2022, 2:34 PM

Mentee reassignment of other mentors can also be found in the log mentioned in T304428.

kostajh triaged this task as High priority.Jun 7 2022, 3:06 PM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh added a subscriber: Urbanecm_WMF.
Urbanecm_WMF claimed this task.Jun 9 2022, 4:58 PM
Urbanecm_WMF added a project: User-Urbanecm_WMF (Engineering).

That's weird. I'll check this ASAP. Thanks for reporting!

gerritbot added a comment.Jun 10 2022, 9:56 AM

Change 804554 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] QuitMentorship: Only process primary mentors

https://gerrit.wikimedia.org/r/804554

gerritbot added a project: Patch-For-Review.Jun 10 2022, 9:56 AM
Urbanecm_WMF moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.EditedJun 10 2022, 10:06 AM

@Bluehill395 Thanks again for noticing this bug. The issue was caused by a bug in our code. I uploaded a patch to fix that.

To explain the issue my patch fixes, this is what happened here:

  1. GrowthExperiments assigns two mentors to each user: primary mentor (the one shown in the newcomer homepage) and a backup mentor (the one who is sent the questions if the primary mentor is away; backup mentor is not meant to be permanent, GrowthExperiments can change who the backup mentor is, for instance, if they are also away).
  2. QuitMentorship fetches all mentees assigned to a mentor, regardless of the role (ie. this step includes mentees the mentor had as a backup mentor). This is wrong, because backup mentor is updated by GrowthExperiments when the currently assigned one is not suitable (is away or not a mentor anymore), cf. MentorPageMentorManager::getMentorForUser.
  3. For each of the relationships fetched in step 2, it calls ChangeMentor to do the reassignment. ChangeMentor assumes a primary relationship needs to be changed, and changes a perfectly valid relationship.

My patch fixes that by only fetching primary assignments in the 2nd step.

Urbanecm_WMF moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Jun 11 2022, 4:14 PM
gerritbot added a comment.Jun 13 2022, 9:34 AM

Change 804554 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] QuitMentorship: Only process primary mentors

https://gerrit.wikimedia.org/r/804554

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 13 2022, 9:41 AM
Urbanecm_WMF moved this task from Backlog to My Part Done on the User-Urbanecm_WMF (Engineering) board.Jun 13 2022, 9:46 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 13 2022, 10:00 AM
gerritbot added a comment.Jun 13 2022, 10:28 AM

Change 805094 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Add QuitMentorshipIntegrationTest

https://gerrit.wikimedia.org/r/805094

gerritbot added a comment.Jun 15 2022, 10:04 AM

Change 805094 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add QuitMentorshipIntegrationTest

https://gerrit.wikimedia.org/r/805094

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.17; 2022-06-20); removed MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 15 2022, 11:00 AM
Bluehill395 closed this task as Resolved.Jun 17 2022, 10:17 AM

Thanks Martin!

https://ko.wikipedia.org/wiki/%ED%8A%B9%EC%88%98:%EA%B8%B0%EB%A1%9D?type=growthexperiments&user=&page=&wpdate=2022-06-17&tagfilter=&subtype=setmentor&uselang=en

It seems to be fixed now.

Urbanecm_WMF added a comment.Jun 19 2022, 5:55 AM

Thanks for the message @Bluehill395. I'm glad it works now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL