@Urbanecm_WMF @RHo — is customization of mentorship-related notifications is in the roadmap for mentor dashboard?

In T304428#7802022, @mewoph wrote:

@Urbanecm_WMF @RHo — is customization of mentorship-related notifications is in the roadmap for mentor dashboard?

Thanks for the ping. The logs should be already hidden from recent changes (see code), so this looks like a bug for me. I can confirm by querying the analytics replica that the bot flag was not set for some reason.

AFAIK we don't have any plans to change how mentor reassignment notifications work, but there's a task for it: T298070: Special:QuitMentorship notifications might be disruptive. Maybe we can discuss possible improvements there? I added my thoughts there. @Stang I encourage you to read my comment at the other task – I have a question for you there as well. Thanks!

Replied in T298070.

Hi @Urbanecm_WMF - I agree with @Stang and @Tgr comments on T298070 as well as the suggestions on this one, in that it seems far more disruptive to the majority of newcomers who have low/no contact with their mentor to be told via notifications when their mentor retires or is changed in some way.

Could the notifications be restricted to only being sent to those newcomers who have posted a question to that mentor before in their mentor/help module? That way, we avoid people who have never engaged with Username:Rho2017 being surprised by a "change of mentor" message since they likely won't notice.

In T304428#7804692, @RHo wrote:

Hi @Urbanecm_WMF - I agree with @Stang and @Tgr comments on T298070 as well as the suggestions on this one, in that it seems far more disruptive to the majority of newcomers who have low/no contact with their mentor to be told via notifications when their mentor retires or is changed in some way.

Could the notifications be restricted to only being sent to those newcomers who have posted a question to that mentor before in their mentor/help module? That way, we avoid people who have never engaged with Username:Rho2017 being surprised by a "change of mentor" message since they likely won't notice.

Yes, that should definitely be possible (and personally, I think that's fine. @Stang, would it resolve the issue?

Looks good to me if notification is only shown to those posted a question via mentor module. Thanks!

Change 896045 had a related patch set uploaded (by Msz2001; author: Msz2001):

[mediawiki/core@master] RecentChange: Log entries of not-bots can be internally marked as such

https://gerrit.wikimedia.org/r/896045

Change 897186 had a related patch set uploaded (by Msz2001; author: Msz2001):

[mediawiki/extensions/GrowthExperiments@master] Bulk mentor reassignment won't spam RecentChanges

https://gerrit.wikimedia.org/r/897186

Change 896045 abandoned by Msz2001:

[mediawiki/core@master] RecentChange: Log entries of not-bots can be internally marked as such

Reason:

Change 742208 covers this already

https://gerrit.wikimedia.org/r/896045

The fix is ready, but requires another change, 742208, to be merged into mediawiki core.

Change 742208 had a related patch set uploaded (by Urbanecm; author: Matěj Suchánek):

[mediawiki/core@master] Allow marking recent changes about logged actions with bot flag

https://gerrit.wikimedia.org/r/742208

Change 742208 merged by jenkins-bot:

[mediawiki/core@master] Allow marking recent changes about logged actions with bot flag

https://gerrit.wikimedia.org/r/742208

In T304428#8685681, @Msz2001 wrote:

The fix is ready, but requires another change, 742208, to be merged into mediawiki core.

Thanks for providing the fix here! I've reviewed your patch and merged the core change. I think your patch should also remove the current treatment (which is broken), ie. call to addTemporaryUserRights from ReassignMentees::doReassignMentees. Once that's done, I'll be happy to merge the GrowthExperiments patch as well.

Change 897186 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Bulk mentor reassignment won't spam RecentChanges

https://gerrit.wikimedia.org/r/897186