Page MenuHomePhabricator
Create Task
Maniphest T310012

require a function when creating an implementation
Closed, ResolvedPublic
Actions

Description

right now the UI lets you create an implementation that is not attached to the function. This returns a "malformed" error because an implementation is actually required, so we should make a function required in order to click the save button (we should also probably add specificity to that error on the frontend)

Details

SubjectRepoBranchLines +/-
do not enable save button until zImplementation or zTester has a function associated with itmediawiki/extensions/WikiLambdamaster+23 -13
Customize query in gerrit

Event Timeline

• JKieserman created this task.Jun 6 2022, 6:29 PM
DVrandecic moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Jun 7 2022, 6:43 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
gengh added projects: Abstract Wikipedia Fix-It tasks, WikiLambda, WikiLambda Front-end.Aug 2 2022, 12:42 PM
gengh moved this task from Incoming to Ready: G5. Fallback view on the Abstract Wikipedia team (Phase θ – Throttling) board.
• JKieserman changed the task status from Open to In Progress.Aug 11 2022, 10:32 AM
• JKieserman claimed this task.
gerritbot added a comment.Aug 15 2022, 10:36 AM

Change 823119 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] do not enable save button until zImplementation or zTester has a function associated with it

https://gerrit.wikimedia.org/r/823119

gerritbot added a project: Patch-For-Review.Aug 15 2022, 10:36 AM
Jdforrester-WMF moved this task from Ready: G5. Fallback view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Aug 15 2022, 2:07 PM
gerritbot added a comment.Aug 15 2022, 2:29 PM

Change 823119 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] do not enable save button until zImplementation or zTester has a function associated with it

https://gerrit.wikimedia.org/r/823119

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 15 2022, 3:01 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 15 2022, 3:31 PM
gengh closed this task as Resolved.Sep 6 2022, 4:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL