Page MenuHomePhabricator
Create Task
Maniphest T310850

Phabricator loading outdated JavaScript
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Go to devtools, debugger and search for get_metadata or set_metadata or write_metadata

What happens?:
No results

What should have happened instead?:
There should be some references according to https://phabricator.wikimedia.org/source/phabricator/browse/wmf%252Fstable/webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js$22

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Caching issue?
This is partly to blame for T310833. Files should automatically get attached when you drag and drop files, but this is not happening due to outdated resources being loaded.

Related Objects
Search...

Event Timeline

Dylsss created this task.Jun 17 2022, 3:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2022, 3:01 AM
Dylsss mentioned this in T310833: Uploaded files via the drag-and-drop are defaulting to private-access.Jun 17 2022, 3:14 AM
brennen subscribed.Jun 17 2022, 6:17 AM

Good catch! One thought is maybe a bin/celerity run is needed somewhere in the chain here? Will dig into this.

brennen added a comment.Jun 17 2022, 6:21 PM

It looks to me like I missed adding the results of bin/celerity map when tagging this release. From my CLI history, it did get run:

120548  2022-06-03 17:30:03     git add resources/celerity/map.php
120544  2022-06-03 17:28:45     git diff resources/celerity/map.php
120534  2022-06-03 17:25:48     bin/celerity map

...but at some point while figuring out the release process we must have rewritten the git history in question.

I think this will require a fresh tag and re-deploy, which is not going to happen today; will coordinate that early next week.

brennen claimed this task.Jun 17 2022, 6:22 PM
brennen added a parent task: T310833: Uploaded files via the drag-and-drop are defaulting to private-access.
brennen added a project: User-brennen.
brennen set the point value for this task to 3.
Krinkle awarded a token.Jun 18 2022, 12:29 AM
matmarex subscribed.Jun 20 2022, 6:51 PM
brennen mentioned this in T311175: Deploy Phabricator release/2022-06-22/1.Jun 22 2022, 7:36 PM
brennen added a comment.Jun 23 2022, 12:09 AM

Check on the mic:

brontosaurus_is_rad.png (486×800 px, 209 KB)

brennen closed this task as Resolved.Jun 23 2022, 12:18 AM
brennen moved this task from Backlog to Done or Declined on the User-brennen board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL