Setting project to Wikimedia-Site-requests, as this request is about settings / configuration of a Wikimedia website and not about the QuickSurveys codebase itself.

Change 807202 had a related patch set uploaded (by DDesouza; author: DDesouza):

[operations/mediawiki-config@master] QuickSurveys: Deploy research-incentive to jawiki on Beta Cluster

https://gerrit.wikimedia.org/r/807202

Change 807206 had a related patch set uploaded (by DDesouza; author: DDesouza):

[mediawiki/extensions/WikimediaMessages@master] Add messages for Research Incentive QuickSurvey

https://gerrit.wikimedia.org/r/807206

Change 807206 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Add messages for Research Incentive QuickSurvey

https://gerrit.wikimedia.org/r/807206

Thanks for notifying Performance Team as per the documentation. When is is the prod date expected? It's been a while we measured a survey. We'd like to do some perf measurements before launch. Either through a demo survey by parameter in prod, or during the day or two that it's on Beta Cluster only.

@Krinkle Deployment to Cluster Beta is scheduled for tomorrow afternoon. (14:00 UTC) If everything is good I will schedule deployment to production as soon as you notify me that all is good. Should I deploy to production with 0 coverage first?

Change 807202 merged by jenkins-bot:

[operations/mediawiki-config@master] QuickSurveys: Deploy research-incentive to jawiki on Beta Cluster

https://gerrit.wikimedia.org/r/807202

Change 808017 had a related patch set uploaded (by DDesouza; author: DDesouza):

[mediawiki/extensions/WikimediaMessages@master] Fix 'en' on 'Research Incentive' QuickSurvey

https://gerrit.wikimedia.org/r/808017

Extension and survey were enabled on Japanese Wiki on Beta but aren't working.

How to test?

Run

mw.loader.using('ext.quicksurveys.init')
  .then(() => {
    mw.extQuickSurveys.showSurvey('research-incentive');
  });

on https://ja.wikipedia.beta.wmflabs.org/wiki/%E6%9C%AC%E6%89%80%E4%B8%8A%E6%B0%B4

Change 808035 had a related patch set uploaded (by DDesouza; author: DDesouza):

[operations/mediawiki-config@master] QuickSurveys (beta): Fix typo and deploy to 'enwiki'

https://gerrit.wikimedia.org/r/808035

Change 808035 merged by jenkins-bot:

[operations/mediawiki-config@master] QuickSurveys (beta): Fix typo and deploy to 'enwiki'

https://gerrit.wikimedia.org/r/808035

Scheduled deployment to production on 30/Jun at late backport window.

Change 808305 had a related patch set uploaded (by DDesouza; author: DDesouza):

[mediawiki/extensions/WikimediaMessages@master] Add extra messages for Research Incentive survey

https://gerrit.wikimedia.org/r/808305

Change 808305 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Add extra messages for Research Incentive survey

https://gerrit.wikimedia.org/r/808305

Notes from comparing these two (logged-out, after 1 warmup and dismissing CentralNotice, Chrome, 3G Fast, CPU unthrottled):

• https://ja.wikipedia.beta.wmflabs.org/wiki/本所上水
• https://ja.wikipedia.beta.wmflabs.org/wiki/本所上水?quicksurvey=research-incentive

First, from a functional perspective I notice:

• MW deprecation warning: Use of new Vue(...) is deprecated. Use Vue.createMwApp() instead. This presumably comes from QuickSurveys use of WVUI.
• Review of change 808017 to en.json translation - possibly problematic for jawiki accounts having a non-Japanese interface language set.
• Chrome warning (5x): Error with Permissions-Policy header: Unrecognized origin: 'intake-analytics.wikimedia.org'. Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'interest-cohort'.. This is unrelated to QuickSurveys. [1]

A quick analysis from a perf timeline capture:

• The vue+wvui payload is okay-ish, and what we know and expect/tolerate for sampled/temporary campaigns:
  • .. transfer 95kB on page load,
  • .. compile 298 kB of code after decompession.
  • .. 4ms (unthrottled) to define and export Vue.
  • .. 6ms (unthrottled) to define and export WVUI.
• The ext.quicksurveys.lib/vue/ render() function
  • .. takes ~40ms to sychronously execute when unthrottled on a MacBook Pro in Chrome. That's a lot of raw compute to concatenate and parse a 0.9kB string of HTML. I expect that on more representative hardware, it easily goes to 100ms or more beyond the 50ms long task threshold.
  • .. a notable portion of this time is spent creating and manipulating a DOM hierachy for survey.link message, which is then discarded and casted to a string fed to the URL constructor. This looks to me like a bug as presumably we do not intend to support HTML or wikitext syntax inside a URL.

var externalLink = survey.link ? new mw.Uri( mw.message( survey.link ).parse() ) : '';

I thought perhaps it uses parse() as hack to support $N-message parameters, but no parameters are passed (And that would normally be done via mw.message().text, mw.msg, or mw.format). Removing that would shave off 10% of the Vue rendering time.

[1] Full response header from https://intake-analytics.wikimedia.beta.wmflabs.org:

…
permissions-policy: interest-cohort=(),ch-ua-arch=(self "intake-analytics.wikimedia.org"),ch-ua-bitness=(self "intake-analytics.wikimedia.org"),ch-ua-full-version-list=(self "intake-analytics.wikimedia.org"),ch-ua-model=(self "intake-analytics.wikimedia.org"),ch-ua-platform-version=(self "intake-analytics.wikimedia.org")

@DDeSouza I left a suggestion on change 808017. The above perf analysis found a regression (or previously missed issue for QuickSurveys maintainers to evaluate for next time. I do not consider it urgent for your needs.

Thanks @Krinkle

Change 808017 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Update 'en' on Research Incentive survey

https://gerrit.wikimedia.org/r/808017

Change 808943 had a related patch set uploaded (by DDesouza; author: DDesouza):

[mediawiki/extensions/WikimediaMessages@master] Update 'en' external link on research incentive survey

https://gerrit.wikimedia.org/r/808943

@DDeSouza I apologize if the following is not open to changes, but the former designer in me has to share a a minor thing I noticed in the survey itself.

1. Casing of project names (Wikidata, not WikiData; Meta-Wiki, not MetaWiki). See also https://wikimedia.org and m:Our projects.
2. The bubbles for questions besides question 9 are possibly of too low color contrast (difficult to read), as per Wikimedia Design: Accessibility principles.

I don't know the significance of these colours (perhaps the meaning of the text has explicit reliance on these colours), and if Design supplied these, then by all means do ignore me; but perhaps the question 9 colors could be considered for the other questions as well. That'd improve readability by a lot, I think!

Q 10	Q 9	Q 7 and 8

@Krinkle I will forward it.

@Krinkle , Thanks for bringing those things to our attention. I've updated the form with your suggestions.

Change 808943 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Update 'en' external link on research incentive survey

https://gerrit.wikimedia.org/r/808943

Change 806960 merged by jenkins-bot:

[operations/mediawiki-config@master] QuickSurveys: Deploy research-incentive to jawiki

https://gerrit.wikimedia.org/r/806960

Change 809961 had a related patch set uploaded (by DDesouza; author: DDesouza):

[operations/mediawiki-config@master] Jawiki: Enable research incentive survey

https://gerrit.wikimedia.org/r/809961

Change 809961 merged by jenkins-bot:

[operations/mediawiki-config@master] QuickSurveys: Enable 'research-incentive' survey on 'jawiki'

https://gerrit.wikimedia.org/r/809961

Mentioned in SAL (#wikimedia-operations) [2022-06-30T22:28:45Z] <cjming@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:809961|QuickSurveys: Enable 'research-incentive' survey on 'jawiki' (T311015)]] (duration: 03m 40s)

Configuration wasn't properly deployed. Possibly due to:

https://phabricator.wikimedia.org/T311788#8042804

Survey is live with reduced coverage.

The JA survey is pointing to the EN link due to T311822

Change 811335 had a related patch set uploaded (by DDesouza; author: DDesouza):

[operations/mediawiki-config@master] QuickSurveys: Increase coverage of 'research-incentive' survey

https://gerrit.wikimedia.org/r/811335

Change 811335 merged by jenkins-bot:

[operations/mediawiki-config@master] QuickSurveys: Increase coverage of 'research-incentive' survey

https://gerrit.wikimedia.org/r/811335

Mentioned in SAL (#wikimedia-operations) [2022-07-05T20:17:46Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 66c973087b7736b22ce7edb5b830e50e31710e4a: QuickSurveys: Increase coverage of research-incentive survey (T311015) (duration: 03m 28s)

Change 812377 had a related patch set uploaded (by DDesouza; author: DDesouza):

[operations/mediawiki-config@master] QuickSurveys: Disable 'research-incentive'

https://gerrit.wikimedia.org/r/812377

Change 812377 merged by jenkins-bot:

[operations/mediawiki-config@master] QuickSurveys: Undeploy 'research-incentive'

https://gerrit.wikimedia.org/r/812377

Mentioned in SAL (#wikimedia-operations) [2022-07-13T20:59:17Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:812377|QuickSurveys: Undeploy 'research-incentive' (T311015)]] (1/2, prod) (duration: 02m 48s)

Mentioned in SAL (#wikimedia-operations) [2022-07-13T21:02:24Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:812377|QuickSurveys: Undeploy 'research-incentive' (T311015)]] (2/2, beta) (duration: 02m 58s)

Survey reached it's goal and was undeployed.

Change 824283 had a related patch set uploaded (by DDesouza; author: DDesouza):

[operations/mediawiki-config@master] QuickSurveys: Disable extension on JA wiki

https://gerrit.wikimedia.org/r/824283

Change 824283 merged by jenkins-bot:

[operations/mediawiki-config@master] QuickSurveys: Disable extension on JA wiki

https://gerrit.wikimedia.org/r/824283

Mentioned in SAL (#wikimedia-operations) [2022-08-17T20:22:19Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 1ddc661e6e73b60542e31d2128c2add3e2307b74: QuickSurveys: Disable extension on JA wiki (T311015) (duration: 03m 19s)

In T311015#8028198, @Krinkle wrote:

• Chrome warning (5x): Error with Permissions-Policy header: Unrecognized origin: 'intake-analytics.wikimedia.org'. Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'interest-cohort'.. This is unrelated to QuickSurveys.

I've reported this bug here: T316760: Error with Permissions-Policy header: Unrecognized origin: 'intake-analytics.wikimedia.org'

The rest of your analysis is excellent and shouldn't be lost. Would you mind if I created a task/set of tasks from it?

In T311015#8201974, @phuedx wrote:

[..]

The rest of your analysis is excellent and shouldn't be lost. Would you mind if I created a task/set of tasks from it?

Thanks, yes feel free to.