| SBisson | |
| Jun 24 2022, 10:32 AM |
| F35272969: image.png | |
| Jun 24 2022, 10:38 PM |
In the best case, if you open a story and let it play from beginning to end, the story_frames_viewed field is too small by 1.
If you use the frame navigation and close the story from a earlier frame, the story_frames_viewed field is off by a lot.
Basically, this field uses the currentFrame.index prop so it may have been right before the cover page and frame navigation but now it is wrong. We have to keep track of all the frames that have been viewed.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix Log Story Viewer in navigation case | mediawiki/extensions/Wikistories | master | +23 -19 |
Change 808203 had a related patch set uploaded (by Huei Tan; author: Huei Tan):
[mediawiki/extensions/Wikistories@master] Log Story Viewer event when close, go to next story, or leaving to edit page
Change 808203 merged by jenkins-bot:
[mediawiki/extensions/Wikistories@master] Fix Log Story Viewer in navigation case
Testing
I tried a number of scenarios and the logs matches the frames viewed each time.
