Page MenuHomePhabricator
Create Task
Maniphest T311594

Wikidata Query Service UI: Remove maps download option that is not actually working
Closed, ResolvedPublic
Actions

Description

Main components:

  • WDQS UI

Problem:
WDQI UI allows users to export their query results in various formats. The problem is that downloading the query result map as an .svg results in a dummy download (see T307957). This obviously leads to confusion.

Example:
see T307957: Fix SVG export for maps in WDQI UI

Solution:
We disable the maps svg download option.

Acceptance criteria:

  • the maps svg download option has been removed

Original:
see T307957: Fix SVG export for maps in WDQI UI

Details

SubjectRepoBranchLines +/-
Merging from 77db0250a5222086941bbb1d90a44ddc489746b2wikidata/query/gui-deployproduction+4 -4
Disable SVG downloads for unsupported result viewswikidata/query/guimaster+30 -7
Customize query in gerrit

Related Objects

Event Timeline

Manuel created this task.Jun 29 2022, 8:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2022, 8:35 AM
Manuel mentioned this in T307957: Fix SVG export for maps in WDQI UI .Jun 29 2022, 8:39 AM
Manuel updated the task description. (Show Details)
Maintenance_bot added a project: Wikidata.Jun 29 2022, 9:29 AM
Bugreporter added a project: Wikidata Query UI.Jul 8 2022, 7:45 PM
Manuel moved this task from Incoming to Unconnected Stories on the Wikidata-Campsite board.Jul 12 2022, 11:42 AM
Manuel updated the task description. (Show Details)Oct 18 2022, 12:23 PM
Lydia_Pintscher added a project: Wikidata Dev Team.Dec 2 2022, 3:31 PM
Lydia_Pintscher moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.
Lydia_Pintscher triaged this task as Medium priority.Dec 4 2022, 12:32 PM
Lydia_Pintscher renamed this task from Disable all options that are not actually available to users in WDQS UI to Wikidata Query Service UI: Disable maps download option that is not actually working.Dec 5 2022, 3:28 PM
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Dec 5 2022, 3:36 PM
Lydia_Pintscher renamed this task from Wikidata Query Service UI: Disable maps download option that is not actually working to Wikidata Query Service UI: Remove maps download option that is not actually working.Dec 6 2022, 3:11 PM
Lucas_Werkmeister_WMDE mentioned this in T324841: Result view selector starts out with “eye” icon and no label, instead of table icon + label, if no default view specified in query.Dec 9 2022, 12:34 PM
gerritbot added a comment.Dec 9 2022, 12:45 PM

Change 866583 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[wikidata/query/gui@master] Disable SVG downloads for unsupported result views

https://gerrit.wikimedia.org/r/866583

gerritbot added a project: Patch-For-Review.Dec 9 2022, 12:45 PM
Lucas_Werkmeister_WMDE claimed this task.Dec 9 2022, 12:45 PM
Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Peer Review on the Wikidata Dev Team (Sprint-∞) board.

(Forgot to claim the task and move it to Doing before working on it, sorry.)

gerritbot added a comment.Dec 12 2022, 5:04 PM

Change 866583 merged by jenkins-bot:

[wikidata/query/gui@master] Disable SVG downloads for unsupported result views

https://gerrit.wikimedia.org/r/866583

Lucas_Werkmeister_WMDE mentioned this in rWDQG77db0250a522: Disable SVG downloads for unsupported result views.Dec 12 2022, 5:04 PM
gerritbot added a comment.Dec 12 2022, 5:08 PM

Change 867212 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder):

[wikidata/query/gui-deploy@production] Merging from 77db0250a5222086941bbb1d90a44ddc489746b2

https://gerrit.wikimedia.org/r/867212

gerritbot added a comment.Dec 12 2022, 5:10 PM

Change 867212 merged by Lucas Werkmeister (WMDE):

[wikidata/query/gui-deploy@production] Merging from 77db0250a5222086941bbb1d90a44ddc489746b2

https://gerrit.wikimedia.org/r/867212

Lucas_Werkmeister_WMDE moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board.Dec 12 2022, 5:10 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 12 2022, 5:31 PM
Arian_Bozorg subscribed.Dec 19 2022, 12:29 PM

This looks good to me :)
Thanks Lucas

Arian_Bozorg closed this task as Resolved.Dec 19 2022, 12:29 PM
Arian_Bozorg moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.
• karapayneWMDE moved this task from Our work done to 2022 Completed Tasks on the Wikidata Dev Team (Sprint-∞) board.Dec 20 2022, 8:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL