Page MenuHomePhabricator
Create Task
Maniphest T311894

Hard deprecate the Group::insertAfter() function in Minerva
Closed, ResolvedPublic
Actions

Description

Based on feedback provided in Gerrit patch 807177, the Group::insertAfter() function should first be deprecated before being deleted.

A hard deprecation is being chosen over a soft deprecation because this function is unused in the codebase. More information about deprecation can be found here.

If the deprecated code is unused in Wikimedia maintained code at the time of deprecation, it SHOULD be hard deprecated immediately.

Acceptance criteria

  • The code is hard deprecated
  • The deprecation appears in the release notes

Details

SubjectRepoBranchLines +/-
Group.php: Hard deprecate insertAfter() functionmediawiki/skins/MinervaNeuemaster+4 -163
Customize query in gerrit

Related Objects
Search...

Event Timeline

Scardenasmolinar created this task.Jul 2 2022, 2:17 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJul 2 2022, 2:17 AM
Scardenasmolinar added a parent task: T221004: Simplify MainMenu building in Minerva skin.Jul 2 2022, 2:19 AM
Scardenasmolinar updated the task description. (Show Details)Jul 2 2022, 2:22 AM
Scardenasmolinar mentioned this in T311895: [1.40] Remove the Group::insertAfter() function in Minerva.
Scardenasmolinar added a subtask: T311895: [1.40] Remove the Group::insertAfter() function in Minerva.
Aklapper added a project: MinervaNeue.Jul 2 2022, 3:35 PM

@Scardenasmolinar: Assuming this task is about the MinervaNeue code project, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. Please set appropriate project tags when possible. Thanks!

Scardenasmolinar added a project: Web-Team-Backlog.Jul 7 2022, 1:52 AM
gerritbot added a comment.Jul 7 2022, 1:59 AM

Change 811799 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/skins/MinervaNeue@master] Group.php: Hard deprecate insertAfter() function

https://gerrit.wikimedia.org/r/811799

gerritbot added a project: Patch-For-Review.Jul 7 2022, 1:59 AM
Scardenasmolinar moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Jul 7 2022, 2:47 AM
Scardenasmolinar added a subscriber: ovasileva.

@ovasileva Hello! This is ready for review by the web team. It's a pretty small patch and a follow-up to T221004.

Jdlrobson awarded a token.Jul 7 2022, 10:17 PM
Scardenasmolinar moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Jul 7 2022, 11:02 PM
gerritbot added a comment.Jul 7 2022, 11:15 PM

Change 811799 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Group.php: Hard deprecate insertAfter() function

https://gerrit.wikimedia.org/r/811799

Maintenance_bot removed a project: Patch-For-Review.Jul 7 2022, 11:30 PM
Jdlrobson moved this task from Incoming to Needs Prioritization (Tech) on the Web-Team-Backlog board.Jul 8 2022, 6:11 PM
Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog.
Jdlrobson moved this task from Backlog to Menus on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jul 8 2022, 6:43 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 5:02 AM
Jdlrobson closed this task as Resolved.Jul 19 2022, 6:17 PM
Jdlrobson mentioned this in T313339: [1.40] Remove Group::insertAfter() function in Minerva.
Jdlrobson subscribed.

Thanks for working on this! I've created T313339 to make sure we eventually remove this!

Scardenasmolinar added a comment.Jul 19 2022, 6:25 PM

I also created T311895 to remind ourselves to remove this.

Samwalton9-WMF subscribed.Jul 19 2022, 6:26 PM

I just merged the tickets :)

Jdlrobson closed subtask T311895: [1.40] Remove the Group::insertAfter() function in Minerva as Resolved.Feb 9 2023, 11:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL