Page MenuHomePhabricator

Kill suppression log, move to using suppressed-by-default entries in the deletion log.
Open, NormalPublic

Tokens
"Dislike" token, awarded by MGChecker."Dislike" token, awarded by Morten_Haan."Heartbreak" token, awarded by Luke081515."Dislike" token, awarded by MarcoAurelio.
Assigned To
None
Authored By
Raymond, May 31 2011

Description

Deletion of a page with "Suppress data from administrators as well as others" (known as oversight) does not create an (hidden) entry in the public deletion log.

If oversight was overdone, the oversighter can remove the oversight bit per revision but still no entry in the public deletion log is visible.

Solution: Create an entry in the deletion log and hide it with the same action. Now it would be possible to unhide the deletion log entry in case of an error.


Version: unspecified
Severity: normal

Details

Reference
bz29216

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:35 PM
bzimport set Reference to bz29216.
bzimport added a subscriber: Unknown Object (MLST).
Raymond created this task.May 31 2011, 1:31 PM

So instead of having a suppression log, you propose putting everything into the deletion log as suppressed entries?

Krenair renamed this task from Deletion of a page with "Suppress data from administrators as well as others" does not create an entry in the deletion log to Kill suppression log, move to using suppressed-by-default entries in the deletion log..Apr 4 2015, 1:01 AM
Krenair set Security to None.
Krenair removed a subscriber: Unknown Object (MLST).

Does this relate to T19053?

I don't think so.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2015, 9:28 PM

I don't see the need for this proposed change. It can only confuse people and there is no reason why non-oversighters should see that an oversighter did something. I propose to decline this request.

I'd prefer to do it both in terms of transparency (showing that there is oversighter activity going on is not private in itself) and also to get rid of one or two annoying special cases in the code for that particular log. I'm not going to decline it.

"and also to get rid of one or two annoying special cases in the code for that particular log" - what do you mean? The fact we have a suppression log is good, imho. I mean, where else should you put suppression actions without having others access to it? Is this only about a suppression where one deletes+suppress a page at the same time?

IIRC there's a couple of cases where we have to check for that log specifically, and this isn't really extendable to other logs.

The fact we have a suppression log is good, imho. I mean, where else should you put suppression actions without having others access to it?

In the deletion log with auto-suppression of the log entry itself controlling access to the private parts of the entries. In practice this might make the log more difficult to read and audit though.

Is this only about a suppression where one deletes+suppress a page at the same time?

Don't think so.

I am not sure if I agree with this change. Create a (log action removed) log entry in the deletion log looks useless for me. If we, for example, delete a page with suppression and we later notice that the OS was a mistake, a page restoring would fix it. The log will be viewable by OS.

Restricted Application added a subscriber: JEumerus. · View Herald TranscriptJan 24 2016, 2:47 PM

There're also usability concerns — we'd need to make it non-annoying for Oversighters to view the log of recent suppressions.

E.g. here's what a suppressed deletion log entry looks like for me as an Oversighter on testwiki:

So to view that log entry, I need to check the box next to it, then "Change visibility of selected revisions".

We could just show suppressed log entries to oversighters without any action on their part. But in general, we only show suppressed information to oversighters after they've taken explicit action to do so; this makes it harder for them to accidentally disclose sensitive content to e.g. a non-oversighter who's over-shoulder.

Luke081515 added a subscriber: Luke081515.
MGChecker added a subscriber: MGChecker.
Meno25 removed a subscriber: Meno25.Nov 23 2018, 7:35 AM