Page MenuHomePhabricator

Migrate usage of Database::select to SelectQueryBuilder in NavigationTiming
Closed, ResolvedPublic

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Event Timeline

Krinkle claimed this task.
Krinkle added subscribers: Ladsgroup, Krinkle.

@Ladsgroup Afaik we don't have any database queries in the NavigationTiming extension. I ran a search to be sure and found no matches for "Database" or "select". Closing as such, but please re-open if I missed it.