Page MenuHomePhabricator
Create Task
Maniphest T312421

Migrate usage of Database::select to SelectQueryBuilder in CirrusSearch
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Details

SubjectRepoBranchLines +/-
Migrate to IReadableDatabase::newSelectQueryBuildermediawiki/extensions/CirrusSearchmaster+36 -13
Fix appending of join condsmediawiki/extensions/CirrusSearchmaster+1 -1
Fix appending of join condsmediawiki/extensions/CirrusSearchwmf/1.39.0-wmf.23+1 -1
Migrate usage of Database::select to SelectQueryBuildermediawiki/extensions/CirrusSearchmaster+16 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

Maintenance_bot created this task.Jul 7 2022, 6:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2022, 6:27 AM
Ladsgroup added a project: CirrusSearch.Jul 7 2022, 6:56 AM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptJul 7 2022, 6:56 AM
• MPhamWMF triaged this task as Low priority.Jul 18 2022, 3:39 PM
• MPhamWMF moved this task from needs triage to elastic / cirrus on the Discovery-Search board.
• MPhamWMF moved this task from elastic / cirrus to Current work on the Discovery-Search board.Jul 18 2022, 3:41 PM
• MPhamWMF edited projects, added Discovery-Search (Current work); removed Discovery-Search.
• EJoseph claimed this task.Jul 18 2022, 3:56 PM
• MPhamWMF set the point value for this task to 3.Jul 25 2022, 3:55 PM
• MPhamWMF moved this task from Incoming to Ready for Dev -- SWE on the Discovery-Search (Current work) board.
gerritbot added a comment.Jul 28 2022, 9:20 AM

Change 818066 had a related patch set uploaded (by EJoseph; author: EJoseph):

[mediawiki/extensions/CirrusSearch@master] Migrate usage of Database::select to SelectQueryBuilder

https://gerrit.wikimedia.org/r/818066

gerritbot added a project: Patch-For-Review.Jul 28 2022, 9:20 AM
• EJoseph moved this task from Ready for Dev -- SWE to Needs review on the Discovery-Search (Current work) board.Jul 28 2022, 9:22 AM
gerritbot added a comment.Aug 1 2022, 5:28 PM

Change 818066 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Migrate usage of Database::select to SelectQueryBuilder

https://gerrit.wikimedia.org/r/818066

Maintenance_bot removed a project: Patch-For-Review.Aug 1 2022, 5:31 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Aug 1 2022, 6:00 PM
gerritbot added a comment.Aug 2 2022, 8:58 PM

Change 819746 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CirrusSearch@master] Fix appending of join conds

https://gerrit.wikimedia.org/r/819746

gerritbot added a project: Patch-For-Review.Aug 2 2022, 8:58 PM
gerritbot added a comment.Aug 2 2022, 9:02 PM

Change 819621 had a related patch set uploaded (by Ladsgroup; author: Zabe):

[mediawiki/extensions/CirrusSearch@wmf/1.39.0-wmf.23] Fix appending of join conds

https://gerrit.wikimedia.org/r/819621

gerritbot added a comment.Aug 2 2022, 9:25 PM

Change 819621 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@wmf/1.39.0-wmf.23] Fix appending of join conds

https://gerrit.wikimedia.org/r/819621

Stashbot added a comment.Aug 2 2022, 9:29 PM

Mentioned in SAL (#wikimedia-operations) [2022-08-02T21:29:13Z] <ladsgroup@deploy1002> Synchronized php-1.39.0-wmf.23/extensions/CirrusSearch/includes/Sanity/Checker.php: Backport: [[gerrit:819621|Fix appending of join conds (T312421 T314439)]] (duration: 03m 15s)

Stashbot mentioned this in T314439: InvalidArgumentException: Wikimedia\Rdbms\JoinGroupBase::addJoin: $table must be either string, JoinGroup or SelectQueryBuilder.Aug 2 2022, 9:29 PM
gerritbot added a comment.Aug 2 2022, 9:39 PM

Change 819746 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Fix appending of join conds

https://gerrit.wikimedia.org/r/819746

• EJoseph moved this task from Needs review to To Be Deployed on the Discovery-Search (Current work) board.Aug 8 2022, 3:25 PM
EBernhardson moved this task from To Be Deployed to Needs Reporting on the Discovery-Search (Current work) board.Aug 22 2022, 3:16 PM
Gehel closed this task as Resolved.Aug 29 2022, 2:32 PM
gerritbot added a comment.Apr 29 2024, 9:29 PM

Change #1025471 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CirrusSearch@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1025471

gerritbot added a comment.Apr 29 2024, 10:49 PM

Change #1025471 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1025471

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).Apr 29 2024, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 29 2024, 11:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits