Page MenuHomePhabricator
Create Task
Maniphest T312551

🟥️ Create RemoveStatementRouteHandler
Closed, ResolvedPublic
Actions

Description

  • get parameters and create RemoveItemStatementRequest
  • execute the use case
  • handle use case responses (success/redirect/error)
  • return HTTP response
  • unexpected error handling
  • edit service wiring and route files
  • create e2e-tests

Details

SubjectRepoBranchLines +/-
REST: Improve RemoveStatementRouteHandlermediawiki/extensions/Wikibasemaster+21 -22
REST: Allow DELETE requests with an empty json bodymediawiki/extensions/Wikibasemaster+124 -27
REST: Create RemoveStatementRouteHandlermediawiki/extensions/Wikibasemaster+427 -3
REST: Allow DELETE requests with empty json bodymediawiki/extensions/Wikibasemaster+23 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Silvan_WMDE renamed this task from Create RemoveStatementRouteHandler to 🟥️ Create RemoveStatementRouteHandler .Jul 7 2022, 2:29 PM
Silvan_WMDE created this task.
Ollie.Shotton_WMDE mentioned this in T312561: 🟥️ Create RemoveItemStatementRouteHandler.Jul 7 2022, 3:16 PM
Silvan_WMDE claimed this task.Jul 20 2022, 10:17 AM
Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 10) board.
gerritbot added a comment.Jul 22 2022, 9:28 AM

Change 816117 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Create RemoveStatementRouteHandler

https://gerrit.wikimedia.org/r/816117

gerritbot added a project: Patch-For-Review.Jul 22 2022, 9:28 AM
gerritbot added a comment.Jul 25 2022, 4:23 PM

Change 816820 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Add BodyValidator to handle empty requests

https://gerrit.wikimedia.org/r/816820

gerritbot added a comment.Jul 25 2022, 4:23 PM

Change 816821 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Allow DELETE requests with empty json body

https://gerrit.wikimedia.org/r/816821

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 10) board.Jul 25 2022, 5:28 PM
gerritbot added a comment.Jul 26 2022, 7:57 AM

Change 816821 abandoned by Silvan Heintze:

[mediawiki/extensions/Wikibase@master] REST: Allow DELETE requests with empty json body

Reason:

squashed into I251287951bfad23416b92dc8fefe04321c2d9727

https://gerrit.wikimedia.org/r/816821

WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 11); removed Wikibase Product Platform (v1) (Sprint 10).Jul 27 2022, 9:18 AM
WMDE-leszek moved this task from To Do to Peer Review on the Wikibase Product Platform (v1) (Sprint 11) board.
gerritbot added a comment.Jul 27 2022, 11:55 AM

Change 816117 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Create RemoveStatementRouteHandler

https://gerrit.wikimedia.org/r/816117

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Jul 27 2022, 12:00 PM
gerritbot added a comment.Jul 27 2022, 1:53 PM

Change 816820 abandoned by Silvan Heintze:

[mediawiki/extensions/Wikibase@master] REST: Allow DELETE requests with an empty json body

Reason:

Empty bodies are not valid json

https://gerrit.wikimedia.org/r/816820

Maintenance_bot removed a project: Patch-For-Review.Jul 27 2022, 2:31 PM
gerritbot added a comment.Jul 27 2022, 3:32 PM

Change 817803 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] Improve RemoveStatementRouteHandler

https://gerrit.wikimedia.org/r/817803

gerritbot added a project: Patch-For-Review.Jul 27 2022, 3:32 PM
Silvan_WMDE added a comment.Jul 27 2022, 6:52 PM
In T312551#8108743, @gerritbot wrote:

Change 817803 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

This remains in Peer Review since patch 817803 is still to be reviewed.

gerritbot added a comment.Jul 28 2022, 10:13 AM

Change 817803 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Improve RemoveStatementRouteHandler

https://gerrit.wikimedia.org/r/817803

Maintenance_bot removed a project: Patch-For-Review.Jul 28 2022, 10:30 AM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 11) board.Jul 28 2022, 12:17 PM
Aklapper closed this task as Resolved.Oct 10 2022, 9:51 AM

@Silvan_WMDE: Assuming this task is resolved. Thus setting resolved task status. Please reopen and add an active project tag if that is not the case. Thanks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits