Page MenuHomePhabricator

The width of the frameless "Subscribe" button changes with the button label in the new Topic container
Open, Needs TriagePublic

Description

Steps to reproduce this issue:

  1. Make sure you are logged in and have "Discussion Tools" enabled from Beta features.
  2. Go to this page: https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:RYasmeen_(WMF)
  3. Click on the "Subscribe/Unsubscribe" button next to a topic.

Observe that, the width of the frameless "Subscribe" button keeps changing when the label changes on click.

Event Timeline

You mean that the bell icon moves horizontally around? For me, it’s the expected way, since the button is right-aligned. If the button was not resized, there was a white space on its right when the shorter of the two button texts is displayed, which may be quite large depending on the translation. For example, see Spanish:

Screenshot 2022-07-08 at 10-29-14 User talk RYasmeen (WMF) - Wikipedia.png (431×1 px, 101 KB)

The Unsubscribe (Cancelar la suscripción) link is almost twice as long as the Subscribe (Suscribirse), which means that the extra white space on the right is approximately two thirds the size of the button itself. For me, this would just look broken.

This didn't look that odd to me too.