Page MenuHomePhabricator
Create Task
Maniphest T312658

Show Labels from redirected Languages/LexicalCategories?
Closed, ResolvedPublic
Actions

Description

Problem: Currently, if a Special:NewLexemeAlpha form (affects the legacy form as well) is prefilled from the URL, redirects for the Language and Lexical Category Items are not resolved, but instead the ID is shown.

Should we change that? (This probably needs to be answered by @Lydia_Pintscher)

Example link:https://wikidata.beta.wmflabs.org/wiki/Special:NewLexemeAlpha?lemma=Weiterleitungsbeispiel&lexeme-language=Q8&lexicalcategory=Q611788&lemma-language=de

The advantage of the current solution is that users maybe notice that their link is outdated and maybe fix it by replacing the redirected ID with the id of the redirect target.
The disadvantage of the current solution is that they only see the Q-ID of the redirected Item in the form.

Notes

Details

SubjectRepoBranchLines +/-
Use FallbackLabelDescriptionLookupFactory in SpecialNewLexemeAlphamediawiki/extensions/WikibaseLexememaster+12 -12
Use FallbackLabelDescriptionLookupFactory in SpecialNewLexememediawiki/extensions/WikibaseLexememaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Michael created this task.Jul 8 2022, 3:02 PM
Michael updated the task description. (Show Details)Jul 8 2022, 3:09 PM
Maintenance_bot added a project: Wikidata.Jul 8 2022, 3:29 PM
Lydia_Pintscher added a comment.Jul 11 2022, 8:52 AM

Yeah I think we can show the label of the redirect target here.

Lucas_Werkmeister_WMDE subscribed.Jul 11 2022, 10:00 AM

The search results for merged items will only show the item ID, though, and I think this would be pretty hard to change:

image.png (119×726 px, 6 KB)

So this will be inconsistent between when the item is loaded via the URL vs. selected interactively.

Lucas_Werkmeister_WMDE added a comment.Jul 11 2022, 10:21 AM
In T312658#8068781, @Lucas_Werkmeister_WMDE wrote:

The search results for merged items will only show the item ID, though, and I think this would be pretty hard to change:

Hm, nevermind – if we use the new FallbackLabelDescriptionLookupFactory in the ENTITY_SEARCH_CALLBACK entity type wiring (which would be part of T312223), then wbsearchentities starts returning labels for search results that belong to redirected items. (Though I’m pretty sure it doesn’t affect which items get returned in the first place, and that redirected items are only returned if you search for their item ID.) Is that something we want or not?

Michael added a comment.Jul 11 2022, 11:04 AM
In T312658#8068853, @Lucas_Werkmeister_WMDE wrote:
In T312658#8068781, @Lucas_Werkmeister_WMDE wrote:

The search results for merged items will only show the item ID, though, and I think this would be pretty hard to change:

Hm, nevermind – if we use the new FallbackLabelDescriptionLookupFactory in the ENTITY_SEARCH_CALLBACK entity type wiring (which would be part of T312223), then wbsearchentities starts returning labels for search results that belong to redirected items. (Though I’m pretty sure it doesn’t affect which items get returned in the first place, and that redirected items are only returned if you search for their item ID.) Is that something we want or not?

I feel this is something we would want for Special:NewLexeme, but we can probably only have it everywhere or nowhere. And I think this is another product question for @Lydia_Pintscher whether we want it everywhere?

(I tried it out locally, and it works as Lucas suggests)

Lydia_Pintscher added a comment.Jul 11 2022, 11:08 AM

👍

gerritbot added a comment.Jul 11 2022, 2:16 PM

Change 812244 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in SpecialNewLexemeAlpha

https://gerrit.wikimedia.org/r/812244

gerritbot added a project: Patch-For-Review.Jul 11 2022, 2:16 PM

Change 812871 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in SpecialNewLexeme

https://gerrit.wikimedia.org/r/812871

Lydia_Pintscher removed Lydia_Pintscher as the assignee of this task.Jul 12 2022, 10:35 AM
gerritbot added a comment.Jul 13 2022, 11:08 AM

Change 812871 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in SpecialNewLexeme

https://gerrit.wikimedia.org/r/812871

gerritbot added a comment.Jul 13 2022, 11:25 AM

Change 812244 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in SpecialNewLexemeAlpha

https://gerrit.wikimedia.org/r/812244

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2022, 11:30 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 13 2022, 12:00 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 13 2022, 2:44 PM
Lucas_Werkmeister_WMDE claimed this task.

Alright, I think we can call this done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits